Review main Merged

87041[DOCS] Add Webhooks documentation

Lina Wolf CR +2 V +2 Hard +395 −0 updated 11/20/24, 17:26

Commit message

The information in this manual is taken from the Changelog and
can be improved in the future.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Chris Müller +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 2027

Show 12 earlier messages
  1. Lina Wolf uploaded patch set 1 11/18/24, 21:25

  2. core-ci voted on patch set 1 V -1 11/18/24, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69625

  1. Lina Wolf uploaded patch set 2 V -1 11/18/24, 21:35

  2. Lina Wolf uploaded patch set 3 11/18/24, 21:36

  3. core-ci voted on patch set 2 V -1 11/18/24, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69626

  4. core-ci voted on patch set 3 V +1 11/18/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69627

  5. Garvin Hicking voted on patch set 3 CR +1 V +1 11/18/24, 21:44

  6. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 11/18/24, 21:44

  7. Garvin Hicking voted on patch set 4 CR +1 V +1 11/18/24, 21:44

  8. core-ci voted on patch set 4 V +1 11/18/24, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69628

  9. Chris Müller updated the commit message in patch set 5 CR +1 V +1 11/19/24, 06:11

  10. core-ci voted on patch set 5 V +1 11/19/24, 06:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69658

  11. Chris Müller commented on patch set 5 CR -1 11/19/24, 06:20

    Index.rst:14

    TYPO3 core -> TYPO3 Core

    Index.rst:26

    Please link to the "TYPO3 queue documentation".

    Index.rst:13

    If you have a code block, the list points should be avoided. Otherwise remove the code-block directive.

    Index.rst:18

    hash_hmac -> hash_hmac()

    Sitemap.rst:3

    Please adjust indentation

    Sitemap.rst:11

    Please adjust indentation

    Index.rst:8

    TYPO3 core -> TYPO3 Core

    Index.rst:23

    Maybe instead of "will" use "may". Webhooks has been introduced with v12 and in v13 no new triggers were added.

    Index.rst:33

    Events -> events

    Index.rst:53

    createFromEvent -> createFromEvent()

    Index.rst:54

    jsonSerialize -> jsonSerialize()

    Index.rst:58

    services.yaml -> Services.yaml

    Index.rst:61

    services.yaml -> Services.yaml

    Index.rst:66

    services.yaml -> Services.yaml

    Index.rst:77

    createFromEvent -> createFromEvent()

    _FolderAddedMessage.php:2

    Please add declare(strict_types=1); as best practise.

    _FolderAddedMessage.php:3

    Vendor -> MyVendor

    _PageModificationListener.php:2

    Please add declare(strict_types=1); as best practise.

    _PageModificationListener.php:3

    Vendor -> MyVendor
  12. Oli Bartsch commented on patch set 5 CR -1 11/19/24, 08:03

    The -1 is just to make sure I'll get the time to review this today.
  13. Lina Wolf commented on patch set 5 11/19/24, 08:08

    Index.rst:23 Reply

    I would remove the seentence parts. If hooks are added in the future we will document them
  14. Lina Wolf uploaded patch set 6 CR -1 V +1 11/19/24, 08:14

  15. Lina Wolf commented on patch set 6 11/19/24, 08:15

    Index.rst:14 Reply

    Done

    Index.rst:26 Reply

    Done

    Index.rst:13 Reply

    Done

    Index.rst:18 Reply

    Done

    Sitemap.rst:3 Reply

    Done

    Sitemap.rst:11 Reply

    Done

    Index.rst:8 Reply

    Done

    Index.rst:23 Reply

    Done

    Index.rst:53 Reply

    Done

    Index.rst:54 Reply

    Done

    Index.rst:58 Reply

    Done

    Index.rst:61 Reply

    Done

    Index.rst:66 Reply

    Done

    Index.rst:77 Reply

    Done

    _FolderAddedMessage.php:2 Reply

    Done

    _FolderAddedMessage.php:3 Reply

    Done

    _PageModificationListener.php:2 Reply

    Done

    _PageModificationListener.php:3 Reply

    Done
  16. Lina Wolf uploaded patch set 7 11/19/24, 08:16

  17. Lina Wolf commented on patch set 7 11/19/24, 08:16

    Index.rst:33 Reply

    Done
  18. core-ci voted on patch set 6 V +1 11/19/24, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69667

  19. core-ci voted on patch set 7 V +1 11/19/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69668

  20. Oli Bartsch commented on patch set 7 11/20/24, 16:13

    Reply

    Done
  21. Garvin Hicking voted on patch set 7 CR +1 V +1 11/20/24, 16:51

  22. Chris Müller voted on patch set 7 CR +1 11/20/24, 16:51

  23. Anja Leichsenring voted on patch set 7 CR +1 V +1 11/20/24, 17:06

  24. Garvin Hicking voted on patch set 7 CR +2 V +2 11/20/24, 17:07

  25. Garvin Hicking merged patch set 8 11/20/24, 17:26