87041[DOCS] Add Webhooks documentation
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Chris Müller +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 12
- typo3/sysext/webhooks/Documentation/AdvancedUsage/Index.rst4new+27 −0
- typo3/sysext/webhooks/Documentation/HashCalculation/Index.rst4new+39 −0
- typo3/sysext/webhooks/Documentation/Installation/Index.rstnew+51 −0
- typo3/sysext/webhooks/Documentation/Introduction/Index.rstnew+22 −0
- typo3/sysext/webhooks/Documentation/Triggers/_snippets/_FolderAddedMessage.php4new+37 −0
- typo3/sysext/webhooks/Documentation/Triggers/_snippets/_PageModificationListener.php4new+37 −0
- typo3/sysext/webhooks/Documentation/Triggers/_snippets/_Services.yamlnew+7 −0
- typo3/sysext/webhooks/Documentation/Triggers/Index.rst19new+86 −0
- typo3/sysext/webhooks/Documentation/guides.xmlnew+20 −0
- typo3/sysext/webhooks/Documentation/Includes.rst.txtnew+1 −0
- typo3/sysext/webhooks/Documentation/Index.rstnew+57 −0
- typo3/sysext/webhooks/Documentation/Sitemap.rst4new+11 −0
Review log 2027
Show 12 earlier messages
-
Lina Wolf uploaded patch set 1 11/18/24, 21:25
-
core-ci voted on patch set 1 V -1 11/18/24, 21:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69625
-
Lina Wolf uploaded patch set 2
V -111/18/24, 21:35 -
Lina Wolf uploaded patch set 3 11/18/24, 21:36
-
core-ci voted on patch set 2 V -1 11/18/24, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69626
-
core-ci voted on patch set 3 V +1 11/18/24, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69627
-
Garvin Hicking voted on patch set 3 CR +1 V +1 11/18/24, 21:44
-
Garvin Hicking updated the commit message in patch set 4
CR +1V +111/18/24, 21:44 -
Garvin Hicking voted on patch set 4 CR +1 V +1 11/18/24, 21:44
-
core-ci voted on patch set 4 V +1 11/18/24, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69628
-
Chris Müller updated the commit message in patch set 5
CR +1V +111/19/24, 06:11 -
core-ci voted on patch set 5 V +1 11/19/24, 06:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69658
-
Chris Müller commented on patch set 5 CR -1 11/19/24, 06:20
Index.rst:26Please link to the "TYPO3 queue documentation".Index.rst:13If you have a code block, the list points should be avoided. Otherwise remove the code-block directive.Index.rst:18hash_hmac -> hash_hmac()Sitemap.rst:3Please adjust indentationSitemap.rst:11Please adjust indentationIndex.rst:8TYPO3 core -> TYPO3 CoreIndex.rst:23Maybe instead of "will" use "may". Webhooks has been introduced with v12 and in v13 no new triggers were added.Index.rst:33Events -> eventsIndex.rst:53createFromEvent -> createFromEvent()Index.rst:54jsonSerialize -> jsonSerialize()Index.rst:58services.yaml -> Services.yamlIndex.rst:61services.yaml -> Services.yamlIndex.rst:66services.yaml -> Services.yamlIndex.rst:77createFromEvent -> createFromEvent()_FolderAddedMessage.php:2Please add declare(strict_types=1); as best practise._FolderAddedMessage.php:3Vendor -> MyVendor_PageModificationListener.php:2Please add declare(strict_types=1); as best practise._PageModificationListener.php:3Vendor -> MyVendor -
Oli Bartsch commented on patch set 5 CR -1 11/19/24, 08:03
The -1 is just to make sure I'll get the time to review this today. -
Lina Wolf commented on patch set 5 11/19/24, 08:08
Index.rst:23ReplyI would remove the seentence parts. If hooks are added in the future we will document them -
Lina Wolf uploaded patch set 6
CR -1V +111/19/24, 08:14 -
Lina Wolf commented on patch set 6 11/19/24, 08:15
Index.rst:14ReplyDoneIndex.rst:26ReplyDoneIndex.rst:13ReplyDoneIndex.rst:18ReplyDoneSitemap.rst:3ReplyDoneSitemap.rst:11ReplyDoneIndex.rst:8ReplyDoneIndex.rst:23ReplyDoneIndex.rst:53ReplyDoneIndex.rst:54ReplyDoneIndex.rst:58ReplyDoneIndex.rst:61ReplyDoneIndex.rst:66ReplyDoneIndex.rst:77ReplyDone_FolderAddedMessage.php:2ReplyDone_FolderAddedMessage.php:3ReplyDone_PageModificationListener.php:2ReplyDone_PageModificationListener.php:3ReplyDone -
Lina Wolf uploaded patch set 7 11/19/24, 08:16
-
Lina Wolf commented on patch set 7 11/19/24, 08:16
Index.rst:33ReplyDone -
core-ci voted on patch set 6 V +1 11/19/24, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69667
-
core-ci voted on patch set 7 V +1 11/19/24, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69668
-
Oli Bartsch commented on patch set 7 11/20/24, 16:13
Reply
Done -
Garvin Hicking voted on patch set 7 CR +1 V +1 11/20/24, 16:51
-
Chris Müller voted on patch set 7 CR +1 11/20/24, 16:51
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 11/20/24, 17:06
-
Garvin Hicking voted on patch set 7 CR +2 V +2 11/20/24, 17:07
-
Garvin Hicking merged patch set 8 11/20/24, 17:26
Index.rst:14