Review main Merged

87046[BUGFIX] Resolve RecordPropertyClosure for flex fields

Oli Bartsch CR +2 V +2 Hard +415 −27 updated 11/19/24, 15:10

Commit message

This introduces a new model class `FlexFormFieldValues`,
which represents a record's flex field values. By
implementing `ContainerInterface` and `ArrayAccess`,
it allows to access the property values in fluid
templates with various available syntaxes. Most
importantly, in case a flex field value is a
`RecordPropertyClosure`, it's now resolved properly.
This works recursively and the resolved value is
"persisted" so does not need to be resolved again.

Support for fields with dot syntax, e.g. "some.field"
is implemented as well.

Due to `ContainerInterface` and `ArrayAccess`,
accessing such property is possible via:

- $field['some']['field']
- $field->get('some')['field']
- $field->get('some.field')

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1422

  1. Oli Bartsch uploaded patch set 1 11/18/24, 22:18

  2. core-ci voted on patch set 1 V -1 11/18/24, 22:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69635

  3. Oli Bartsch uploaded patch set 2 V -1 11/19/24, 09:29

  4. core-ci voted on patch set 2 V +1 11/19/24, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69675

  5. Oli Bartsch uploaded patch set 3 V +1 11/19/24, 10:24

  6. core-ci voted on patch set 3 V -1 11/19/24, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69682

  7. Oli Bartsch uploaded patch set 4 V -1 11/19/24, 10:49

  8. Oli Bartsch uploaded patch set 5 11/19/24, 10:52

  9. core-ci voted on patch set 4 V -1 11/19/24, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69684

  10. core-ci voted on patch set 5 V -1 11/19/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69685

  11. Oli Bartsch uploaded patch set 6 V -1 11/19/24, 11:01

  12. core-ci voted on patch set 6 V +1 11/19/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69687

  13. Nikita Hovratov commented on patch set 6 11/19/24, 12:52

    RecordFieldTransformerTest.php:1408

    duplicate assert
  14. Nikita Hovratov uploaded patch set 7 V +1 11/19/24, 13:08

  15. Nikita Hovratov commented on patch set 7 CR +1 V +1 11/19/24, 13:08

    RecordFieldTransformerTest.php:1408 Reply

    Done
  16. core-ci voted on patch set 7 V +1 11/19/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69706

  17. Oli Bartsch uploaded patch set 8 CR +1 V +1 11/19/24, 13:27

  18. core-ci voted on patch set 8 V +1 11/19/24, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69709

  19. Nikita Hovratov voted on patch set 8 CR +1 V +1 11/19/24, 14:29

  20. Benni Mack voted on patch set 8 CR +1 V +1 11/19/24, 14:40

  21. Oli Bartsch voted on patch set 8 CR +2 V +2 11/19/24, 15:10

  22. Oli Bartsch merged patch set 9 11/19/24, 15:10