Review main Merged

87049[TASK] Increase Uri test coverage

Benjamin Franzke CR +2 V +2 Easy +23 −0 updated 11/19/24, 08:58

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Benjamin Franzke uploaded patch set 1 11/18/24, 22:37

  2. core-ci voted on patch set 1 V +1 11/18/24, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69638

  3. Garvin Hicking commented on patch set 1 11/18/24, 23:00

    UriTest.php:111

    typo, "alike"
  4. Benjamin Franzke uploaded patch set 2 V +1 11/18/24, 23:14

  5. Benjamin Franzke commented on patch set 2 11/18/24, 23:14

    UriTest.php:111 Reply

    🤦 – thx!
  6. Garvin Hicking voted on patch set 2 CR +1 V +1 11/18/24, 23:21

  7. core-ci voted on patch set 2 V +1 11/18/24, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69639

  8. Elias Häußler uploaded patch set 3 CR +1 V +1 11/19/24, 08:21

  9. Elias Häußler voted on patch set 3 CR +1 V +1 11/19/24, 08:21

  10. core-ci voted on patch set 3 V +1 11/19/24, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69669

  11. Garvin Hicking voted on patch set 3 CR +1 V +1 11/19/24, 08:54

  12. Benjamin Franzke voted on patch set 3 CR +2 V +2 11/19/24, 08:58

  13. Benjamin Franzke merged patch set 4 11/19/24, 08:58