Review main Merged

87051[TASK] Avoid friendsoftypo3/phpstan-typo3

Christian Kuhn CR +2 V +2 Normal +11 −53 updated 11/19/24, 13:41

Commit message

In preparation of phpstan v2, we review our phpstan
extensions. Looking closer at friendsoftypo3/phpstan-typo3,
most of it is obsolete meanwhile, we can get rid of
the dependency. Details:

* phpstan finds most constants manually, except CR and
  LF, which we add to phpstan boostrap.
* extbase ObjectManager does not exist anymore since v12
* Context->getAspect() receives a conditional return type
  leading to a very similar solution
* GeneralUtility::makeInstance() has a matching generic
  already
* extbase Query and QueryInterface have generics already,
  a tests needs a minor adaption.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 810

  1. Christian Kuhn uploaded patch set 1 11/19/24, 01:26

  2. core-ci voted on patch set 1 V +1 11/19/24, 01:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69645

  3. Christian Kuhn uploaded patch set 2 V +1 11/19/24, 11:13

  4. core-ci voted on patch set 2 V +1 11/19/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69688

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 11/19/24, 11:26

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 11/19/24, 11:27

  7. Benni Mack commented on patch set 2 CR +1 11/19/24, 12:16

    found a minor typo in Commit Message, but fine with it.
  8. Christian Kuhn voted on patch set 2 CR +2 V +2 11/19/24, 13:37

  9. Christian Kuhn merged patch set 3 11/19/24, 13:37

  10. Christian Kuhn commented on patch set 3 11/19/24, 13:41

    forgot to document the composer command used, it was of course: composer rem --dev friendsoftypo3/phpstan-typo3