Review 12.4 Merged

87055[TASK] Avoid friendsoftypo3/phpstan-typo3

Christian Kuhn CR +2 V +2 Normal +13 −60 updated 11/19/24, 13:37

Commit message

In preparation of phpstan v2, we review our phpstan
extensions. Looking closer at friendsoftypo3/phpstan-typo3,
most of it is obsolete meanwhile, we can get rid of
the dependency. Details:

* phpstan finds most constants manually, except CR and
  LF, which we add to phpstan boostrap.
* extbase ObjectManager does not exist anymore since v12
* Context->getAspect() receives a conditional return type
  leading to a very similar solution
* GeneralUtility::makeInstance() has a matching generic
  already
* extbase Query and QueryInterface have generics already,
  a tests needs a minor adaption.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 510

  1. Christian Kuhn uploaded patch set 1 11/19/24, 09:43

  2. core-ci voted on patch set 1 V -1 11/19/24, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69679

  3. Christian Kuhn uploaded patch set 2 V -1 11/19/24, 09:52

  4. core-ci voted on patch set 2 V -1 11/19/24, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69680

  5. core-ci voted on patch set 2 V +1 11/19/24, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69680

  6. Christian Kuhn updated the commit message in patch set 3 V +1 11/19/24, 11:13

  7. core-ci voted on patch set 3 V -1 11/19/24, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69690

  8. core-ci voted on patch set 3 V +1 11/19/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69690

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 11/19/24, 13:37

  10. Christian Kuhn merged patch set 4 11/19/24, 13:37