87058[FEATURE] Allow modifying fetched page content
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Documentation/Changelog/13.2/Feature-103894-AdditionalPropertiesForColumnsInPageLayouts.rst+3 −0
- typo3/sysext/core/Documentation/Changelog/13.4.x/Feature-105638-ModifyFetchedPageContent.rstnew+89 −0
- typo3/sysext/core/Documentation/Changelog/13.4.x/Index.rst+5 −4
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+15 −9
- typo3/sysext/frontend/Classes/Event/AfterContentHasBeenFetchedEvent.phpnew+31 −0
Review log 2737
Show 812 earlier messages
-
Oli Bartsch uploaded patch set 1 11/19/24, 14:54
-
Oli Bartsch uploaded patch set 2 11/19/24, 14:56
-
core-ci voted on patch set 2 V +1 11/19/24, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69717
-
core-ci voted on patch set 1 V -1 11/19/24, 15:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69715
-
Oli Bartsch uploaded patch set 3
V +111/19/24, 20:15 -
core-ci voted on patch set 3 V +1 11/19/24, 20:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69749
-
Oli Bartsch uploaded patch set 4
V +111/19/24, 20:26 -
core-ci voted on patch set 4 V +1 11/19/24, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69751
-
Nikita Hovratov commented on patch set 4 CR +1 V +1 11/19/24, 21:58
Verified with Content Blocks: https://github.com/FriendsOfTYPO3/content-blocks/pull/300 -
Garvin Hicking commented on patch set 4 11/20/24, 07:35
Feature-105638-ModifySelectConfigurationForFetchingContent.rst:43We can use an external :ref: here instead, if Nikkita could maybe add a uniqe heading anchor in the docs? I can make a PR there and if its rendered in main we can directly use it here? That would make it portable for future updates to the manual.Feature-105638-ModifySelectConfigurationForFetchingContent.rst:48maybe "member properties of the event object" or so, to be more specific and prevent the "information" plural issue ;)Feature-105638-ModifySelectConfigurationForFetchingContent.rst:53The last two items are missing a ":" for uniformityFeature-105638-ModifySelectConfigurationForFetchingContent.rst:75We can add a caption here for a filename exampleFeature-105638-ModifySelectConfigurationForFetchingContent.rst:84Linebreak for preventing scrollbars here -
Garvin Hicking commented on patch set 4 11/20/24, 07:40
Feature-105638-ModifySelectConfigurationForFetchingContent.rst:43Reply -
Garvin Hicking commented on patch set 5
CR +1V +111/20/24, 08:14Published edit on patch set 4.
-
core-ci voted on patch set 5 V +1 11/20/24, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69770
-
Garvin Hicking commented on patch set 6
V +111/20/24, 08:23Published edit on patch set 5. -
Garvin Hicking commented on patch set 6 11/20/24, 08:23
Feature-105638-ModifySelectConfigurationForFetchingContent.rst:43ReplyDoneFeature-105638-ModifySelectConfigurationForFetchingContent.rst:48ReplyDoneFeature-105638-ModifySelectConfigurationForFetchingContent.rst:53ReplyDoneFeature-105638-ModifySelectConfigurationForFetchingContent.rst:75ReplyDoneFeature-105638-ModifySelectConfigurationForFetchingContent.rst:84ReplyDone -
core-ci voted on patch set 6 V +1 11/20/24, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69771
-
Garvin Hicking voted on patch set 6 CR +1 11/20/24, 08:37
-
Nikita Hovratov voted on patch set 6 CR +1 V +1 11/20/24, 08:39
-
Oli Bartsch commented on patch set 6 CR -1 11/20/24, 08:41
Need to change one detail -
Oli Bartsch uploaded patch set 7
CR +1V +111/20/24, 08:43 -
Oli Bartsch commented on patch set 7 11/20/24, 08:43
Reply
Done -
core-ci voted on patch set 7 V +1 11/20/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69774
-
Nikita Hovratov voted on patch set 7 CR +1 V +1 11/20/24, 08:54
-
Garvin Hicking voted on patch set 7 CR +1 11/20/24, 08:56
-
Oli Bartsch commented on patch set 7 V -1 11/20/24, 10:11
Will rework ;) -
Oli Bartsch uploaded patch set 8
CR +1V +111/20/24, 11:40 -
core-ci voted on patch set 8 V -1 11/20/24, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69784
-
Oli Bartsch uploaded patch set 9
V -111/20/24, 11:48 -
core-ci voted on patch set 9 V +1 11/20/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69785
-
Oli Bartsch commented on patch set 9 11/20/24, 11:58
Reply
Done -
Nikita Hovratov uploaded patch set 10
V +111/20/24, 12:16 -
Nikita Hovratov voted on patch set 10 CR +1 V +1 11/20/24, 12:17
-
core-ci voted on patch set 10 V +1 11/20/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69789
-
Benni Mack voted on patch set 10 CR +1 V +1 11/20/24, 17:31
-
Garvin Hicking voted on patch set 10 CR +1 11/20/24, 17:41
-
Oli Bartsch voted on patch set 10 CR +2 V +2 11/20/24, 18:55
-
Oli Bartsch merged patch set 11 11/20/24, 18:55