Review main Merged

87061[BUGFIX] Mark file-storage caching as active on selection in install tool

Ayke Halder CR +2 V +2 Easy +8 −1 updated 12/19/24, 04:34

Commit message

In "Admin Tools -> Settings -> Configuration Presets: Cache Settings"
a previously selected entry `Prefer File storage for caching` is marked
as active now.

Before a selection of `File storage` resulted in `Custom configuration`
being marked as active on relaod of the `Configuration Presets`-modal.

This also fixes the test-case: The test checks if the radio-button
which is selected has the value `File`.
Before the test only checked if a radio-button having value `File`
exists, but didn't check if this radio-button was actually selected.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Ayke Halder uploaded patch set 1 11/19/24, 15:40

  2. core-ci voted on patch set 1 V +1 11/19/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69720

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 12/18/24, 13:24

  4. Stefan Bürk commented on patch set 1 CR -1 12/18/24, 14:50

    Reviewing ...
  5. Oli Bartsch voted on patch set 1 V +1 12/18/24, 14:58

  6. Stefan Bürk uploaded patch set 2 CR +1 V +1 12/18/24, 16:02

  7. Stefan Bürk commented on patch set 2 CR +1 V +1 12/18/24, 16:02

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 12/18/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71397

  9. Oli Bartsch voted on patch set 2 CR +1 V +1 12/18/24, 21:32

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 12/19/24, 04:12

  11. Stefan Bürk merged patch set 3 12/19/24, 04:34