87061[BUGFIX] Mark file-storage caching as active on selection in install tool
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Ayke Halder uploaded patch set 1 11/19/24, 15:40
-
core-ci voted on patch set 1 V +1 11/19/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69720
-
Ayke Halder commented on patch set 1 11/19/24, 15:52
**About `'__UNSET'` see:** https://github.com/TYPO3/typo3/blob/80e4ff8d5c8edcc332ad76b94c51295b409d09f8/typo3/sysext/core/Classes/Utility/ArrayUtility.php#L677-L683 https://github.com/TYPO3/typo3/blob/80e4ff8d5c8edcc332ad76b94c51295b409d09f8/typo3/sysext/install/Classes/Configuration/Cache/FileCachePreset.php#L36-L42 **Note**-section in https://docs.typo3.org/c/typo3/cms-form/main/en-us/I/Concepts/Variants/Index.html#definition-of-variants > To selectively unset list items in variants like select options the special value `__UNSET` can be used as value for the item to remove. -
Andreas Kienast voted on patch set 1 CR +1 V +1 12/18/24, 13:24
-
Stefan Bürk commented on patch set 1 CR -1 12/18/24, 14:50
Reviewing ... -
Oli Bartsch voted on patch set 1 V +1 12/18/24, 14:58
-
Stefan Bürk uploaded patch set 2
CR +1V +112/18/24, 16:02 -
Stefan Bürk commented on patch set 2 CR +1 V +1 12/18/24, 16:02
Reply
Done -
core-ci voted on patch set 2 V +1 12/18/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71397
-
Oli Bartsch voted on patch set 2 CR +1 V +1 12/18/24, 21:32
-
Stefan Bürk voted on patch set 2 CR +2 V +2 12/19/24, 04:12
-
Stefan Bürk merged patch set 3 12/19/24, 04:34