Review main Merged

87065[TASK] Make CKEditor context aware

Andreas Nedbal CR +2 V +2 Normal +52 −0 updated 11/21/24, 07:55

Commit message

This patch adds dark mode capabilities to the CKEditor
interface. The contents area is not touched in terms
of styling, aside of always enforcing light mode inside
it, to prevent issues with globally styled elements like
tables.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Josef Glatz +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Andreas Nedbal uploaded patch set 1 11/19/24, 18:10

  2. core-ci voted on patch set 1 V +1 11/19/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69739

  3. Josef Glatz commented on patch set 1 CR +1 V +1 11/20/24, 08:18

    Works from my POV as expected. (tough I'm no a11y specialist)
  4. Andreas Kienast voted on patch set 1 CR +1 V +1 11/20/24, 10:49

  5. Benjamin Kott voted on patch set 1 CR -1 11/20/24, 19:11

  6. Benjamin Kott uploaded patch set 2 CR +1 V +1 11/20/24, 19:58

  7. core-ci voted on patch set 2 V -1 11/20/24, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69862

  8. Andreas Nedbal uploaded patch set 3 V -1 11/20/24, 20:22

  9. core-ci voted on patch set 3 V +1 11/20/24, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69868

  10. Benjamin Kott voted on patch set 3 CR +1 V +1 11/20/24, 21:03

  11. Josef Glatz commented on patch set 3 CR +1 V +1 11/21/24, 04:35

    there might be
  12. Andreas Kienast commented on patch set 3 11/21/24, 07:37

    Reply

    What do you mean?
  13. Andreas Kienast voted on patch set 3 CR +2 V +2 11/21/24, 07:47

  14. Andreas Kienast merged patch set 4 11/21/24, 07:55