Review main Merged

87069[TASK] Use American English in xlf files

Peter Kraume CR +2 V +2 Easy +14 −14 updated 11/20/24, 11:21

Commit message

This patch standardizes different spellings to American English.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Josef Glatz +1
    • Preben Sørensen +1
    • Xavier Perseguers +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Preben Sørensen +1
    • Xavier Perseguers +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2123

  1. Peter Kraume uploaded patch set 1 11/19/24, 20:12

  2. core-ci voted on patch set 1 V +1 11/19/24, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69748

  3. Josef Glatz commented on patch set 1 11/20/24, 06:12

    Do we have such standards already documented anywhere on docs.typo3.org? I often asked myself about uk and american english
  4. Chris Müller commented on patch set 1 11/20/24, 06:51

  5. Chris Müller voted on patch set 1 CR +1 V +1 11/20/24, 06:55

  6. Preben Sørensen voted on patch set 1 CR +1 V +1 11/20/24, 09:04

  7. Josef Glatz voted on patch set 1 CR +1 V +1 11/20/24, 09:07

  8. Josef Glatz commented on patch set 1 11/20/24, 09:07

    Reply

    Done
  9. Xavier Perseguers commented on patch set 1 CR -1 11/20/24, 09:09

    locallang_login.xlf:52

    must be plural.
  10. Peter Kraume uploaded patch set 2 CR +1 V +1 11/20/24, 09:13

  11. Xavier Perseguers voted on patch set 2 CR +1 V +1 11/20/24, 09:16

  12. Preben Sørensen commented on patch set 2 CR +1 V +1 11/20/24, 09:16

    locallang_login.xlf:52 Reply

    Done
  13. core-ci voted on patch set 2 V +1 11/20/24, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69777

  14. Benni Mack commented on patch set 2 11/20/24, 09:27

    excellent work!

    locallang_tabs.xlf:31

    how about we duplicate this entry "behaviour" into "behavior" so people can also reference the "correct" entry then.

    locallang_tca.xlf:120

    same as above we could add "sys_file_metadata.color_space.gray"

    locallang_tca.xlf:250

    same as above

    locallang_ttc.xlf:451

    same as above
  15. Peter Kraume commented on patch set 2 11/20/24, 09:45

    Reply

    Thx for pointing that out Josef and Chris for the link. I'll check out if there is a possibility to add that information also to the core contribution guide.

    locallang_login.xlf:52 Reply

    Done

    locallang_tabs.xlf:31 Reply

    We on the localization team thought about fixing the label keys as well, but decided to go with the pragmatic solution for now. Some of our thoughts: - duplicate entries can confuse users - event if it's just 4 places it is additional work for translators - we could do it as breaking change in the next major version and add an upgrade wizard - but for custom extensions using core labels even with Rector it would be almost impossible to prevent breaking things That's why we decided to stick with the current wrong spelled keys. But we're open for to discussing this further.
  16. Josef Glatz voted on patch set 2 CR +1 11/20/24, 09:49

  17. Josef Glatz commented on patch set 2 11/20/24, 09:55

    Reply

    can we also add language specific infos like "du schreibweise" for german translations, and so on?
  18. Peter Kraume commented on patch set 2 11/20/24, 09:59

    Reply

    Yes, that's on my todo list already 😊
  19. Christian Kuhn commented on patch set 2 CR +1 V +1 11/20/24, 10:36

    that would be fine with me. good with you, too, benni?

    locallang_tabs.xlf:31 Reply

    understood. the reasoning is fine with me.

    locallang_tca.xlf:120 Reply

    i hope its ok to set this resolved with the same reasoning as above.

    locallang_tca.xlf:250 Reply

    Done

    locallang_ttc.xlf:451 Reply

    Done
  20. Peter Kraume commented on patch set 2 11/20/24, 10:39

    Reply

    I will take care to update the documentation today.
  21. Benni Mack commented on patch set 2 CR +1 11/20/24, 10:50

    fine by me
  22. Christian Kuhn voted on patch set 2 CR +2 V +2 11/20/24, 10:54

  23. Christian Kuhn merged patch set 3 11/20/24, 11:21