Review 12.4 Merged

87080[DOCS] Add missing anchors in dashboard manual

Garvin Hicking CR +2 V +2 Normal +112 −48 updated 11/19/24, 14:14

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 813

  1. Garvin Hicking commented on patch set 1 11/19/24, 12:54

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/dashboard/Documentation/Developer/GraphWidgetImplementation.rst * typo3/sysext/dashboard/Documentation/Developer/WidgetImplementation.rst
  2. core-ci voted on patch set 1 V -1 11/19/24, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69704

  3. Garvin Hicking marked it ready for review 11/19/24, 13:15

  4. Lina Wolf rebased onto patch set 2 V -1 11/19/24, 13:34

  5. Lina Wolf uploaded patch set 3 11/19/24, 13:37

  6. core-ci voted on patch set 2 V +1 11/19/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69710

  7. core-ci voted on patch set 3 V +1 11/19/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69711

  8. Garvin Hicking commented on patch set 3 CR -1 11/19/24, 13:53

    on it

    WidgetImplementation.rst:168

    merge conflict remainder

    WidgetImplementation.rst:215

    merge conflict remainder
  9. Garvin Hicking commented on patch set 4 CR -1 V +1 11/19/24, 14:01

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V -1 11/19/24, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69712

  11. core-ci voted on patch set 4 V +1 11/19/24, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69712

  12. Garvin Hicking commented on patch set 4 CR +2 V +2 11/19/24, 14:14

    WidgetImplementation.rst:168 Reply

    Done

    WidgetImplementation.rst:215 Reply

    Done
  13. Garvin Hicking merged patch set 5 11/19/24, 14:14