87086[BUGFIX] Cast tag-content of several ViewHelpers to string
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 39
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php+1 −1
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/EditRecordViewHelperTest.php+15 −0
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/NewRecordViewHelperTest.php+15 −0
- typo3/sysext/dashboard/Classes/ViewHelpers/Widget/ButtonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Form/Select/OptionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ButtonViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ExternalViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/FileViewHelper.php+2 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+3 −3
- typo3/sysext/fluid/Tests/Functional/Fixtures/ViewHelpers/Link/FileViewHelper/Template.html+2 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/CssViewHelperTest.php+12 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.php+12 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/InfoboxViewHelperTest.phpnew+44 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/LinkViewHelperTest.php+20 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/ButtonViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/SelectViewHelperTest.php+105 −0
Show 19 more files
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/BytesViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CropViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/CurrencyViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/DateViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlentitiesDecodeViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlentitiesViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/PaddingViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ActionViewHelperTest.php+15 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+5 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ExternalViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/FileViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+38 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+4 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Sanitize/HtmlViewHelperTest.php+2 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Transform/HtmlViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/CObjectViewHelperTest.php+22 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FlashMessagesViewHelperTest.php+12 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php+8 −0
Review log 610
-
Garvin Hicking commented on patch set 1 11/19/24, 16:48
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/Be/InfoboxViewHelper.php * typo3/sysext/fluid/Tests/Functional/ViewHelpers/Asset/ScriptViewHelperTest.php * typo3/sysext/fluid/Tests/Functional/ViewHelpers/FlashMessagesViewHelperTest.php * typo3/sysext/fluid/Tests/Functional/ViewHelpers/Form/Select/OptionViewHelperTest.php -
core-ci voted on patch set 1 V -1 11/19/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69724
-
Garvin Hicking uploaded patch set 2
V -111/19/24, 16:57address merge conflict -
Garvin Hicking uploaded patch set 3 11/19/24, 17:01
Adjust FlashMessagesViewHelperTest -
core-ci voted on patch set 2 V -1 11/19/24, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69727
-
core-ci voted on patch set 3 V -1 11/19/24, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69728
-
Garvin Hicking uploaded patch set 4
V -111/19/24, 17:22Adjust to v12 tests -
Garvin Hicking marked it ready for review 11/19/24, 17:23
-
core-ci voted on patch set 4 V -1 11/19/24, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69729
-
Garvin Hicking abandoned the change 11/19/24, 17:48
Does not apply to 12.4