Review 13.4 Merged

87089[TASK] Add details to CLI scheduler:run exceptions

Garvin Hicking CR +2 V +2 Easy +12 −1 updated 11/22/24, 18:56

Commit message

This adds important information on a failed task to CLI so they're
automatically included in the mails that are being sent by the cron
daemon to MAILTO, as well as being emitted in the CLI output.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Garvin Hicking commented on patch set 1 11/19/24, 17:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/19/24, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69732

  3. Christoph Lehmann commented on patch set 1 11/19/24, 21:24

    SchedulerCommand.php:186

    Also add $e->getLine()and $e->getFile() ?
  4. Garvin Hicking commented on patch set 1 11/19/24, 22:13

    SchedulerCommand.php:186 Reply

    Good idea, could you comment that on the "main" variant of the patch? I'll update this cherry pick then.
  5. Garvin Hicking commented on patch set 2 V +1 11/22/24, 18:46

    Cherry Picked from branch main.
  6. Garvin Hicking commented on patch set 2 CR +1 V +1 11/22/24, 18:47

    SchedulerCommand.php:186 Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/22/24, 18:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70064

  8. Garvin Hicking voted on patch set 2 CR +2 V +2 11/22/24, 18:56

  9. Garvin Hicking merged patch set 3 11/22/24, 18:56