Review main Merged

87092[TASK] Ignore files generated by docs rendering on root level

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 11/20/24, 09:17

Commit message

It's a common use case to render the
documentation on the root level. Those
files are now ignored as well.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Garvin Hicking +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Josef Glatz +1
    • Garvin Hicking +1
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 11/20/24, 08:30

  2. Mathias Brodala commented on patch set 1 11/20/24, 08:36

    .gitignore:79

    Or unified: > Documentation-GENERATED-temp/ So explicitly without leading slash, thus covering every occurrence at any depth.
  3. core-ci voted on patch set 1 V +1 11/20/24, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69772

  4. Oli Bartsch commented on patch set 2 V +1 11/20/24, 08:39

    Published edit on patch set 1.
  5. Oli Bartsch commented on patch set 2 11/20/24, 08:40

    .gitignore:79 Reply

    Acknowledged
  6. Garvin Hicking commented on patch set 2 CR +1 V +1 11/20/24, 08:41

    Great, thanks! Sidenote: This makes it easier to have an alias like ``` alias render-changelog='docker run --rm --pull always -v ./:/project/ ghcr.io/typo3-documentation/render-guides:latest --no-progress --config=typo3/sysext/core/Documentation typo3/sysext/core/Documentation && open Documentation-GENERATED-temp/Index' ``` to easily render the changelogs from the TYPO3 GIT root.
  7. Josef Glatz voted on patch set 2 CR +1 V +1 11/20/24, 08:44

  8. core-ci voted on patch set 2 V +1 11/20/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69773

  9. Mathias Brodala voted on patch set 2 CR +1 V +1 11/20/24, 08:51

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 11/20/24, 09:17

  11. Oli Bartsch merged patch set 3 11/20/24, 09:17