87095[POC] "Apply fallback chain for Extbase entities w/language sets" tests
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+2 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+2 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+28 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php1+15 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/Frontend/ExtbaseJsonRenderer.typoscriptnew+30 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/TranslatedRepositoryTestImport.csvnew+15 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+127 −1
Review log 1622
-
Garvin Hicking uploaded patch set 1 11/20/24, 11:49
-
Garvin Hicking commented on patch set 1 11/20/24, 11:56
Reference: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87036 -
core-ci voted on patch set 1 V -1 11/20/24, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69786
-
Garvin Hicking uploaded patch set 2
V -111/20/24, 12:00 -
core-ci voted on patch set 2 V +1 11/20/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69787
-
Benni Mack commented on patch set 2 12/10/24, 18:14
ha, this is another issue :) https://review.typo3.org/c/Packages/TYPO3.CMS/+/87420ext_localconf.php:27Unresolvedlet's use a more "speakable" plugin name, such as "personList" ? -
Garvin Hicking commented on patch set 2 12/10/24, 18:49
Reply
The problem with this current patch is: Tests are green even without the bugfix that should fix, what doesn't show up as broken atm. I tried to work on it with Achim but I think I produced too much wall of text, and I couldn't figure out why the tests don't fail and what I might be missing. -
Benni Mack commented on patch set 2 12/10/24, 22:01
oh yesReply
oh yes, that's easy to explain. Your example is using personRepository->findAll(), which actually calls Typo3DbBackend which already uses the fallback chain. The places you touched / fixed are with "getObjectByIdentifier" which is basically a "findByUid()" call, and within DataMapper, which is typically called within relations, e.g. "children" (think of blog entity as parent and blogpost entity as child) -
Garvin Hicking commented on patch set 2 12/12/24, 09:17
Reply Unresolved
Ah, I believe I understand. Not sure when I'll find the time in the next weeks to work further on this, but don't let the test block the merge of the actual bugfix if you feel confident. :-) -
Garvin Hicking rebased onto patch set 3
V +103/22/25, 13:17 -
core-ci voted on patch set 3 V +1 03/22/25, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76020
-
Benni Mack commented on patch set 3 03/22/25, 18:52
OK. This took a while, but: congratulations, you added (more) tests for https://review.typo3.org/c/Packages/TYPO3.CMS/+/84017 - which was merged in the meantime. -
Benni Mack uploaded patch set 4
V +103/22/25, 18:54 -
Benni Mack commented on patch set 4 03/22/25, 18:55
Reply
I suggest to abandon this change, and rather get the actual fix in. The actual fix you wanted to provide changes for is really connected to child records. I think we should re-organize Extbase tests at some point... -
Benni Mack marked it work in progress 03/22/25, 18:55
-
Garvin Hicking commented on patch set 4 03/22/25, 18:59
Reply
Yes I already saw this patch here to be distinct. i want to use it as a base for the child test. will rework when I find the time, this is low prio to me -
core-ci voted on patch set 4 V +1 03/22/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76038
-
Benni Mack uploaded patch set 5
V +103/22/25, 19:12 -
Benni Mack uploaded patch set 6 03/22/25, 19:12
-
core-ci voted on patch set 5 V +1 03/22/25, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76039
-
core-ci voted on patch set 6 V +1 03/22/25, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76040
-
Garvin Hicking abandoned the change 03/22/25, 19:26
https://review.typo3.org/c/Packages/TYPO3.CMS/+/87036/2..3 verified what I wanted to check. thanks!!