Review main Merged

87096[TASK] Get rid of "resname" attribute in XLF files

Xavier Perseguers CR +2 V +2 Impossible +53432 −53439 updated 11/21/24, 10:37

Commit message

The change has been prepared with following commands:

```
find . -name \*.xlf -exec sed -I "" \
   -E 's/<trans-unit(.*) resname="[^"]+"(.*)>/<trans-unit\1\2>/' {} \;
./Build/Scripts/updateIsoDatabase.php
git status | grep "modified:" |  cut -d: -f2 \
   | xargs git add
```

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 307

Show 287 more files

Review log 1522

  1. Xavier Perseguers uploaded patch set 1 11/20/24, 12:15

  2. core-ci voted on patch set 1 V +1 11/20/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69788

  3. Xavier Perseguers uploaded patch set 2 V +1 11/20/24, 20:24

  4. core-ci voted on patch set 2 V +1 11/20/24, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69869

  5. Christian Kuhn uploaded patch set 3 V +1 11/20/24, 21:48

  6. core-ci voted on patch set 3 V +1 11/20/24, 21:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69878

  7. Andreas Kienast commented on patch set 3 11/21/24, 08:16

    `resname` also appears in some test fixture files. Should we remove them there as well?
  8. Andreas Kienast commented on patch set 3 CR -1 11/21/24, 09:34

    locallang.xlf:111

    I don't think this should get removed.
  9. Andreas Kienast uploaded patch set 4 CR -1 V +1 11/21/24, 09:42

  10. Andreas Kienast commented on patch set 4 CR -1 11/21/24, 09:43

    still on it
  11. Andreas Kienast uploaded patch set 5 CR -1 11/21/24, 09:47

  12. Andreas Kienast uploaded patch set 6 11/21/24, 09:47

  13. core-ci voted on patch set 4 V +1 11/21/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69904

  14. Andreas Kienast commented on patch set 6 CR +1 V +1 11/21/24, 09:50

    locallang.xlf:111 Reply

    Done
  15. Andreas Kienast commented on patch set 6 11/21/24, 09:51

    Reply

    Done
  16. core-ci voted on patch set 6 V +1 11/21/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69906

  17. core-ci voted on patch set 5 V +1 11/21/24, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69905

  18. Christian Kuhn uploaded patch set 7 CR +1 V +1 11/21/24, 10:17

  19. Christian Kuhn voted on patch set 7 CR +1 V +1 11/21/24, 10:18

  20. Andreas Kienast voted on patch set 7 CR +2 V +2 11/21/24, 10:24

  21. core-ci voted on patch set 7 V +1 11/21/24, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69912

  22. Andreas Kienast merged patch set 8 11/21/24, 10:37