Review main Merged

87099[TASK] Make `SvgSpriteIconProvider` "public"

Andreas Kienast CR +2 V +2 Easy +2 −4 updated 11/20/24, 19:34

Commit message

The `SvgSpriteIconProvider` has been added with 10.4 and is proven to be
stable in use. This commit removes the `@internal` annotation and fixes
some minor issues.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Andreas Kienast uploaded patch set 1 11/20/24, 14:19

  2. core-ci voted on patch set 1 V -1 11/20/24, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69801

  3. Andreas Kienast uploaded patch set 2 V -1 11/20/24, 15:47

  4. core-ci voted on patch set 2 V +1 11/20/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69808

  5. Benni Mack updated the commit message in patch set 3 V +1 11/20/24, 17:30

  6. Benni Mack voted on patch set 3 CR +1 V +1 11/20/24, 17:30

  7. core-ci voted on patch set 3 V +1 11/20/24, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69831

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 11/20/24, 19:01

  9. Christian Kuhn voted on patch set 3 CR +1 11/20/24, 19:02

  10. Andreas Kienast voted on patch set 3 CR +2 V +2 11/20/24, 19:02

  11. Andreas Kienast merged patch set 4 11/20/24, 19:34