Review main Merged

87102[TASK] Add functional DataHandler tests for type=datetime

Benjamin Franzke CR +2 V +2 Hard +491 −0 updated 11/20/24, 21:27

Commit message

Add functional DataHandler tests for type=datetime that assert correct
persistence to database and test in different timezones.

We document current findings and oddities which are to be streamlined
by #105549 in TYPO3 v14.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1422

  1. Benjamin Franzke uploaded patch set 1 11/20/24, 16:28

  2. core-ci voted on patch set 1 V -1 11/20/24, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69816

  3. Benjamin Franzke uploaded patch set 2 V -1 11/20/24, 17:19

  4. core-ci voted on patch set 2 V +1 11/20/24, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69829

  5. Benjamin Franzke uploaded patch set 3 V +1 11/20/24, 18:19

  6. core-ci voted on patch set 3 V +1 11/20/24, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69841

  7. Benjamin Franzke uploaded patch set 4 V +1 11/20/24, 18:37

  8. core-ci voted on patch set 4 V +1 11/20/24, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69843

  9. Benjamin Franzke uploaded patch set 5 V +1 11/20/24, 18:55

  10. Benjamin Franzke marked it ready for review 11/20/24, 18:55

  11. core-ci voted on patch set 5 V +1 11/20/24, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69851

  12. Christian Kuhn commented on patch set 5 CR +1 V +1 11/20/24, 19:13

    nice.
  13. Andreas Kienast voted on patch set 5 CR +1 V +1 11/20/24, 19:16

  14. core-ci voted on patch set 5 V -1 11/20/24, 20:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69861

  15. Benjamin Franzke rebased onto patch set 6 CR +1 V +1 11/20/24, 20:05

  16. Andreas Kienast voted on patch set 6 CR +1 V +1 11/20/24, 20:05

  17. core-ci voted on patch set 6 V +1 11/20/24, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69863

  18. core-ci commented on patch set 6 11/20/24, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69864

  19. Christian Kuhn voted on patch set 6 CR +1 V +1 11/20/24, 21:04

  20. Benjamin Franzke voted on patch set 6 CR +2 V +2 11/20/24, 21:15

  21. Benjamin Franzke merged patch set 7 11/20/24, 21:27