Review main Merged

87109[TASK] Mitigate postgres DB issue in styleguide

Christian Kuhn CR +2 V +2 Easy +8 −0 updated 11/20/24, 19:31

Commit message

Command
> Build/Scripts/runTests.sh -s acceptance -d postgres -i 15 -p 8.3
currently fails since #105595.
It seems either DefaultTcaSchema is wrong with the generated
int field, or DataHandler should avoid writing int 0 when
no row is selected. This needs further analysis. For now,
we create an ext_tables.sql for select_tree_7, that makes
the field a string to prevent red nightlies and gain
some time for further debug of this rather seldom TCA
configuration in combination with postgres.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Christian Kuhn uploaded patch set 1 11/20/24, 18:03

  2. core-ci voted on patch set 1 V +1 11/20/24, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69838

  3. Oli Bartsch voted on patch set 1 CR +1 V +1 11/20/24, 18:52

  4. Oli Bartsch commented on patch set 1 V 0 CR -1 11/20/24, 18:53

    Formatting seems wrong
  5. Oli Bartsch uploaded patch set 2 CR -1 V +1 11/20/24, 18:56

  6. Oli Bartsch commented on patch set 2 CR +1 V +1 11/20/24, 18:56

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/20/24, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69852

  8. core-ci commented on patch set 2 11/20/24, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69853

  9. Andreas Kienast commented on patch set 2 CR +1 V +1 11/20/24, 19:23

  10. Oli Bartsch voted on patch set 2 CR +2 V +2 11/20/24, 19:31

  11. Oli Bartsch merged patch set 3 11/20/24, 19:31