Review 13.4 Merged

87130[TASK] Introduce test of error-handling for FormEngine's basic-inputs

Andreas Kienast CR +2 V +2 Hard +365 −0 updated 11/21/24, 11:43

Commit message

This introduces a multi-step test of the error-handling for
`FormEngineValidation`'s basic input fields.

Normal and unusual test-cases can be easily implemented via test-data
configuration on a element-by-element basis in the corresponding
`ElementsBasic*Cest`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Andreas Kienast commented on patch set 1 11/21/24, 10:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/21/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69917

  3. Ayke Halder commented on patch set 1 11/21/24, 11:07

    Looks like in `TYPO3 v13` the `has-error` class is on the `label`-element instead of the parent `div.form-group` like in `main`. ---- **TYPO3 v13:** ```html <div class="form-group t3js-formengine-validation-marker t3js-formengine-palette-field"> <label for="formengine-input-673f0ffa4449a726286433" class="form-label t3js-formengine-label has-change has-error">input_41 <code>[input_41]</code></label> … </div> . ``` ---- **TYPO3 main:** ```html <div class="form-group t3js-formengine-validation-marker t3js-formengine-palette-field has-error"> <label for="formengine-input-673efe67b784f070473094" class="form-label t3js-formengine-label has-change">input_41</label> … </div> . ```
  4. Andreas Kienast commented on patch set 1 CR -1 11/21/24, 11:22

    Reply

    Nah, this was changed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87136 which was merged today. I'm already on it.
  5. Andreas Kienast uploaded patch set 2 CR -1 V -1 11/21/24, 11:26

  6. core-ci voted on patch set 2 V +1 11/21/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69930

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 11/21/24, 11:43

  8. Andreas Kienast merged patch set 3 11/21/24, 11:43