87130[TASK] Introduce test of error-handling for FormEngine's basic-inputs
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
-
Verified V +2 Done
- Andreas Kienast +2
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/AbstractElementsBasicCest.php+39 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicEmailCest.php+45 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputSimpleCest.php+236 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicNumberCest.php+45 −0
Review log 68
-
Andreas Kienast commented on patch set 1 11/21/24, 10:42
Cherry Picked from branch main. -
core-ci voted on patch set 1 V -1 11/21/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69917
-
Ayke Halder commented on patch set 1 11/21/24, 11:07
Looks like in `TYPO3 v13` the `has-error` class is on the `label`-element instead of the parent `div.form-group` like in `main`. ---- **TYPO3 v13:** ```html <div class="form-group t3js-formengine-validation-marker t3js-formengine-palette-field"> <label for="formengine-input-673f0ffa4449a726286433" class="form-label t3js-formengine-label has-change has-error">input_41 <code>[input_41]</code></label> … </div> . ``` ---- **TYPO3 main:** ```html <div class="form-group t3js-formengine-validation-marker t3js-formengine-palette-field has-error"> <label for="formengine-input-673efe67b784f070473094" class="form-label t3js-formengine-label has-change">input_41</label> … </div> . ``` -
Andreas Kienast commented on patch set 1 CR -1 11/21/24, 11:22
Reply
Nah, this was changed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87136 which was merged today. I'm already on it. -
Andreas Kienast uploaded patch set 2
CR -1V -111/21/24, 11:26 -
core-ci voted on patch set 2 V +1 11/21/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69930
-
Andreas Kienast voted on patch set 2 CR +2 V +2 11/21/24, 11:43
-
Andreas Kienast merged patch set 3 11/21/24, 11:43