Review main Merged

87132[TASK] Use conditional return types in `PathUtility::pathinfo()`

Elias Häußler CR +2 V +2 Easy +1 −3 updated 12/17/24, 13:14

Commit message

The return type of `PathUtility::pathinfo()` is deterministic; it
equals the return type of PHP's native `pathinfo()` function. Thus, the
appropriate annotation is now more explicit and improves DX for
consumers, especially when using static code analysis.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Elias Häußler uploaded patch set 1 11/20/24, 19:40

  2. core-ci voted on patch set 1 V +1 11/20/24, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69860

  3. Benni Mack voted on patch set 1 CR +1 V +1 12/11/24, 16:48

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 12/17/24, 13:14

  5. Christian Kuhn merged patch set 2 12/17/24, 13:14