Review main Merged

87134[TASK] Use `typo3/core-testing-php84:1.5` image for PHP 8.4

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/22/24, 09:28

Commit message

This change updates the image version for
PHP 8.4 to execute PHP 8.4 based tasks
with PHP 8.4.1.

[1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/928f2aeaef07424cd58446216cb086816aef1546

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1317

  1. Stefan Bürk uploaded patch set 1 11/20/24, 20:15

  2. core-ci voted on patch set 1 V +1 11/20/24, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69867

  3. core-ci commented on patch set 1 11/20/24, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69870

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 11/20/24, 21:03

  5. Garvin Hicking voted on patch set 1 CR +1 V +1 11/20/24, 23:13

  6. Andreas Kienast commented on patch set 1 11/21/24, 10:29

    Meh, PHP 8.4.1 has been released today. Does this patch then need adjustments again?
  7. Stefan Bürk commented on patch set 1 CR -1 11/21/24, 19:40

    Reply

    What the heck? 8.4.1 before 8.4.0 stable release ? But you are right: https://www.php.net/archive/2024.php#2024-11-21-4 8.4.0 RC4 (which this should be pull in) and than 8.3.1 from today oO not sure if that is an error. Let's keep this change .. will monitor this and see when/what will be available as official php image and do a build/release of the images with that.
  8. Stefan Bürk commented on patch set 1 11/21/24, 19:42

    Reply

    Seems thath there is an php8.4.0 tag in the github repository from 2 days ago .. but not mentioned on the php.net release list. So let's wait until the images are on docker hub and will create new images with that then.
  9. Stefan Bürk uploaded patch set 2 CR +1 V +1 11/22/24, 07:14

  10. core-ci voted on patch set 2 V +1 11/22/24, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70017

  11. core-ci commented on patch set 2 11/22/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70021

  12. Stefan Bürk commented on patch set 2 11/22/24, 08:00

    Reply

    Done. Updated to 8.4.1 and also created&pulled patchlevel image updates for 8.1, 8.2 and 8.3 (where simple pull is enough and already available).
  13. Andreas Kienast voted on patch set 2 CR +1 V +1 11/22/24, 08:54

  14. Garvin Hicking voted on patch set 2 CR +1 V +1 11/22/24, 09:28

  15. Christian Kuhn voted on patch set 2 CR +1 V +1 11/22/24, 09:28

  16. Stefan Bürk voted on patch set 2 CR +2 V +2 11/22/24, 09:28

  17. Stefan Bürk merged patch set 3 11/22/24, 09:28