Review 13.4 Merged

87137[BUGFIX] Set FormEngine error class on field and its label

Andreas Kienast CR +2 V +2 Easy +9 −9 updated 11/21/24, 09:07

Commit message

Like done for the `has-change` class in #105096
is the FormEngine `has-error` class now added
to the corresponding field and its label instead
of the container element. This prevents wrong
inheritance of the styles, which occurred e.g.
in inline elements.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 11/21/24, 08:58

  2. core-ci voted on patch set 1 V +1 11/21/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69897

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 11/21/24, 09:07

  4. Andreas Kienast merged patch set 2 11/21/24, 09:07