Review main Merged

87138[BUGFIX] Handle invalid site settings definition

Oli Bartsch CR +2 V +2 Normal +62 −2 updated 11/21/24, 14:39

Commit message

Site setting definitions, using invalid
values e.g. an invalid `type` or some `default`
value, which is not valid for the defined
`type` are now marked as invalid on registration
and therefore do not longer trigger errors
in the further program flow.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Lina Wolf +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 912

  1. Oli Bartsch uploaded patch set 1 11/21/24, 10:23

  2. core-ci voted on patch set 1 V +1 11/21/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69913

  3. Benjamin Franzke voted on patch set 1 CR +1 11/21/24, 11:06

  4. Lina Wolf commented on patch set 1 11/21/24, 11:49

    Is renaming the exception breaking maybe?
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 11/21/24, 11:56

  6. Oli Bartsch uploaded patch set 3 11/21/24, 11:57

  7. Lina Wolf voted on patch set 3 CR +1 11/21/24, 11:58

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 11/21/24, 12:01

  9. core-ci voted on patch set 2 V +1 11/21/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69937

  10. core-ci voted on patch set 3 V +1 11/21/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69939

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 11/21/24, 12:55

  12. Benjamin Franzke merged patch set 4 11/21/24, 14:39