87138[BUGFIX] Handle invalid site settings definition
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Lina Wolf +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+1 −1
- typo3/sysext/core/Classes/Site/Set/InvalidSettingsDefinitionsException.php+3 −0
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+14 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SetWithInvalidSettingsDefault/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SetWithInvalidSettingsDefault/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SetWithInvalidSettingsType/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_site_settings/Configuration/Sets/SetWithInvalidSettingsType/settings.definitions.yamlnew+5 −0
- typo3/sysext/core/Tests/Functional/Site/Entity/SiteSettingsTest.php+30 −0
Review log 912
-
Oli Bartsch uploaded patch set 1 11/21/24, 10:23
-
core-ci voted on patch set 1 V +1 11/21/24, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69913
-
Benjamin Franzke voted on patch set 1 CR +1 11/21/24, 11:06
-
Lina Wolf commented on patch set 1 11/21/24, 11:49
Is renaming the exception breaking maybe? -
Oli Bartsch uploaded patch set 2
CR +1V +111/21/24, 11:56 -
Oli Bartsch uploaded patch set 3 11/21/24, 11:57
-
Lina Wolf voted on patch set 3 CR +1 11/21/24, 11:58
-
Andreas Kienast voted on patch set 3 CR +1 V +1 11/21/24, 12:01
-
core-ci voted on patch set 2 V +1 11/21/24, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69937
-
core-ci voted on patch set 3 V +1 11/21/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69939
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 11/21/24, 12:55
-
Benjamin Franzke merged patch set 4 11/21/24, 14:39