Review main Merged

87140[TASK] Add description to scheduler additional fields

Rico Sonntag CR +2 V +2 Easy +12 −0 updated 11/25/24, 19:34

Commit message

This commit adds the description label to the scheduler task
additional fields textarea, select, check and checkToggle.

This makes it much easier to add explanatory descriptions to
a configurable field, making it easier for the editor to
understand how to use it. Furthermore, it would not require
the label to be unnecessarily bloated, but could keep it
short and sweet.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christoph Lehmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Rico Sonntag uploaded patch set 1 11/21/24, 10:35

  2. core-ci voted on patch set 1 V -1 11/21/24, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69915

  3. core-ci commented on patch set 1 11/21/24, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69915

  4. core-ci voted on patch set 1 V +1 11/21/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69915

  5. Christoph Lehmann voted on patch set 1 CR +1 11/22/24, 12:44

  6. Christoph Lehmann commented on patch set 1 11/22/24, 12:45

    {item.description} is also used for inputs and commandOptions, so lets streamline this
  7. Benni Mack voted on patch set 1 CR +1 11/22/24, 15:27

  8. Garvin Hicking commented on patch set 1 CR +1 V +1 11/25/24, 10:23

    Reply

    For these two the description already is emitted (before the patch), or am I misunderstanding?
  9. Jasmina Ließmann commented on patch set 1 CR +2 V +2 11/25/24, 19:34

    Reply

    Yes, for the field types 'input' and 'commandOption' the field description has already been output. Since the markup of the individual field types is partly different, I would suggest that the rendering of "{field.description}" remains within the individual if conditions / field types for now.
  10. Jasmina Ließmann merged patch set 2 11/25/24, 19:34