87140[TASK] Add description to scheduler additional fields
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- Christoph Lehmann +1
- Benni Mack +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 710
-
Rico Sonntag uploaded patch set 1 11/21/24, 10:35
-
core-ci voted on patch set 1 V -1 11/21/24, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69915
-
core-ci commented on patch set 1 11/21/24, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69915
-
core-ci voted on patch set 1 V +1 11/21/24, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69915
-
Christoph Lehmann voted on patch set 1 CR +1 11/22/24, 12:44
-
Christoph Lehmann commented on patch set 1 11/22/24, 12:45
{item.description} is also used for inputs and commandOptions, so lets streamline this -
Benni Mack voted on patch set 1 CR +1 11/22/24, 15:27
-
Garvin Hicking commented on patch set 1 CR +1 V +1 11/25/24, 10:23
Reply
For these two the description already is emitted (before the patch), or am I misunderstanding? -
Jasmina Ließmann commented on patch set 1 CR +2 V +2 11/25/24, 19:34
Reply
Yes, for the field types 'input' and 'commandOption' the field description has already been output. Since the markup of the individual field types is partly different, I would suggest that the rendering of "{field.description}" remains within the individual if conditions / field types for now. -
Jasmina Ließmann merged patch set 2 11/25/24, 19:34