Review 12.4 Merged

87142[TASK] Use phpstan v2

Christian Kuhn CR +2 V +2 Nightmare +4669 −695 updated 11/21/24, 11:44

Commit message

Major tooling upgrade to phpstan v2.

The v2 ruleset compilation finds a set of new
smells that can and will have more detailed
looks with further patches.

Backports down to TYPO3 v12 to ease maintenance by
having only one major tool version for all
maintained branches.

> composer req --dev phpstan/phpstan:^2.0.2 \
                     phpstan/phpstan-phpunit:^2.0.1 \
                     bnf/phpstan-psr-container:^1.1.0
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Christian Kuhn uploaded patch set 1 11/21/24, 11:11

  2. core-ci voted on patch set 1 V +1 11/21/24, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69923

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 11/21/24, 11:44

  4. Christian Kuhn merged patch set 2 11/21/24, 11:44