87144[BUGFIX] Streamline midnight vs null handling of time fields
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 28
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+2 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php2+32 −11
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+87 −7
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+1 −0
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php2+7 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php3+5 −4
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/CategoryTreeCest.php+9 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+276 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/Base.csvnew+5 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/Result.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultBerlinFakeUTC0.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultBerlinLocaltime.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultEmpty.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultNull.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetBerlin.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetUTC.csvnew+8 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultEmpty.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultNull.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeLegacyTest.php2new+125 −0
Show 8 more files
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeTest.php+0 −4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/Configuration/TCA/tx_testdatahandler_datetime_legacy.phpnew+106 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/ext_emconf.phpnew+19 −0
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+45 −18
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatTime.php+6 −19
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeFormatTimesec.php+6 −19
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+16 −0
Review log 1927
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 11/21/24, 11:23
-
core-ci voted on patch set 1 V -1 11/21/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69928
-
Benjamin Franzke uploaded patch set 2
V -111/27/24, 13:05 -
core-ci voted on patch set 2 V -1 11/27/24, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70255
-
Benjamin Franzke uploaded patch set 3
V -111/27/24, 13:42 -
core-ci voted on patch set 3 V -1 11/27/24, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70256
-
Benjamin Franzke uploaded patch set 4
V -111/27/24, 19:35 -
core-ci voted on patch set 4 V +1 11/27/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70278
-
Benjamin Franzke uploaded patch set 5
V +111/27/24, 20:12 -
core-ci voted on patch set 5 V +1 11/27/24, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70280
-
Benjamin Franzke updated the commit message in patch set 6
V +111/28/24, 22:01 -
core-ci voted on patch set 6 V +1 11/28/24, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70319
-
Benjamin Franzke uploaded patch set 7
V +111/29/24, 07:32 -
core-ci voted on patch set 7 V +1 11/29/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70340
-
Benni Mack commented on patch set 7 12/04/24, 11:13
-
Benni Mack voted on patch set 7 CR +1 12/04/24, 11:26
-
Benni Mack voted on patch set 7 V +1 12/04/24, 15:05
-
Andreas Kienast commented on patch set 7 CR -1 12/05/24, 09:14
on it -
Andreas Kienast commented on patch set 7 12/05/24, 09:30
TcaSchemaDatabaseRowDateTimeFields.php:68theoryDataHandler.php:2172`$nativeDateTimeFieldEmptyValue` is potentially undefined, it's defined within `if (in_array($nativeDateTimeType, QueryHelper::getDateTimeTypes(), true)) {` only.DefaultTcaSchema.php:495`$formats` is unusedDatetimeLegacyTest.php:96Why do we need the empty lines? -
Benjamin Franzke uploaded patch set 8
CR +1V +112/05/24, 09:48 -
Benjamin Franzke commented on patch set 8 12/05/24, 09:48
Reply
DoneDatabaseRowDateTimeFields.php:68ReplyDoneDataHandler.php:2172Replyyea, well, statically seen it is always defined as the condition above checks for `isNativeDateTimeField`, therefore phpstan also did not complain. But better to initialize the value anyway, as done for reset before. Done.DefaultTcaSchema.php:495ReplyOoops, left-over of a intermediate change. Thanks!DatetimeLegacyTest.php:96ReplyI applied the newlines because the fields are grouped like this in `DatetimeTest`. But not really needed, removed… -
core-ci voted on patch set 8 V +1 12/05/24, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70636
-
Andreas Kienast voted on patch set 8 CR +1 12/05/24, 10:18
-
Andreas Kienast voted on patch set 8 V +1 12/05/24, 15:07
-
Benni Mack voted on patch set 8 CR +1 V +1 12/06/24, 08:20
-
Benjamin Franzke voted on patch set 8 CR +2 V +2 12/06/24, 09:05
-
Benjamin Franzke merged patch set 9 12/06/24, 09:11
DataHandler.php:2167