Review main Merged

87145[TASK] Use phpstan v2

Christian Kuhn CR +2 V +2 Nightmare +4087 −349 updated 11/21/24, 11:43

Commit message

Major tooling upgrade to phpstan v2.

The v2 ruleset compilation finds a set of new
smells that can and will have more detailed
looks with further patches.

Backports down to TYPO3 v12 to ease maintenance by
having only one major tool version for all
maintained branches.

> composer req --dev phpstan/phpstan:^2.0.2 \
                     phpstan/phpstan-phpunit:^2.0.1 \
                     bnf/phpstan-psr-container:^1.1.0
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 11/21/24, 11:26

  2. core-ci voted on patch set 1 V +1 11/21/24, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69929

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 11/21/24, 11:41

  4. Andreas Kienast voted on patch set 1 CR +1 V +1 11/21/24, 11:42

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 11/21/24, 11:43

  6. Christian Kuhn merged patch set 2 11/21/24, 11:43