Review main Merged

87147[TASK] Make system emails context aware

Andreas Nedbal CR +2 V +2 Normal +90 −17 updated 05/20/25, 10:19

Commit message

This change adapts the default HTML-based
system email layout to support dark / light mode.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1724

  1. Andreas Nedbal uploaded patch set 1 11/21/24, 11:42

  2. core-ci voted on patch set 1 V +1 11/21/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69932

  3. Simon Schaufelberger commented on patch set 1 11/21/24, 12:09

    SystemEmail.html:346

    please be consistent with putting the braces at the end
  4. Andreas Nedbal uploaded patch set 2 V +1 11/21/24, 14:18

  5. Andreas Nedbal commented on patch set 2 11/21/24, 14:19

    SystemEmail.html:346 Reply

    Done
  6. core-ci voted on patch set 2 V -1 11/21/24, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69950

  7. core-ci commented on patch set 2 11/21/24, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69950

  8. Christoph Lehmann commented on patch set 2 11/22/24, 13:40

    For a better understanding mention dark mode / light mode?
  9. Benni Mack commented on patch set 2 04/11/25, 15:45

    any progress here? is this ready to review? Can you please ensure that the CI does not fail?
  10. Andreas Nedbal rebased onto patch set 3 V -1 04/11/25, 15:45

  11. core-ci voted on patch set 3 V -1 04/11/25, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77558

  12. Benni Mack uploaded patch set 4 V -1 04/11/25, 17:10

  13. core-ci voted on patch set 4 V +1 04/11/25, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77565

  14. Benni Mack updated the commit message in patch set 5 V +1 04/11/25, 17:19

  15. Benni Mack commented on patch set 5 04/11/25, 17:20

    Reply

    Done
  16. Benni Mack commented on patch set 5 04/11/25, 17:20

    Reply

    Done
  17. core-ci voted on patch set 5 V +1 04/11/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77567

  18. Benjamin Kott uploaded patch set 6 V +1 05/15/25, 06:04

  19. core-ci voted on patch set 6 V +1 05/15/25, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78937

  20. Benjamin Kott voted on patch set 6 CR +1 V +1 05/15/25, 06:14

  21. Benni Mack voted on patch set 6 CR +1 V +1 05/15/25, 06:30

  22. Benni Mack commented on patch set 6 CR -2 05/16/25, 14:25

    please hold off - I need to check something
  23. Benni Mack voted on patch set 6 CR +2 V +2 05/20/25, 10:19

  24. Benni Mack merged patch set 7 05/20/25, 10:19