87148[TASK] Use phpunit DoesNotPerformAssertions attribute
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 20
- Build/phpstan/phpstan-baseline.neon+0 −36
- Build/phpunit/FunctionalTests.xml+0 −1
- Build/phpunit/UnitTests.xml+0 −1
- typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php+4 −0
- typo3/sysext/core/Tests/Functional/Database/Middleware/CustomPlatformDriverMiddlewareTest.php1+0 −22
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+0 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/CleanSchemaMigrationForAllSystemExtensionTest.php+2 −6
- typo3/sysext/core/Tests/Functional/Database/ConnectionTest.php+5 −0
- typo3/sysext/core/Tests/Functional/Error/ErrorHandlerTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Resource/ProcessedFileTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Session/Backend/DatabaseSessionBackendTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Session/Backend/RedisSessionBackendTest.php+2 −0
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/ExtensionManagementUtilityTcaOverrideRequireTest.php+4 −3
- typo3/sysext/core/Tests/Functional/Utility/ExtensionManagementUtility/ExtensionManagementUtilityTcaRequireTest.php+4 −3
- typo3/sysext/extbase/Tests/Functional/Property/PropertyMapperTest.php+3 −3
- typo3/sysext/form/Tests/Functional/Domain/Configuration/FormDefinitionValidationServiceTest.php+5 −0
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+2 −1
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+5 −4
- typo3/sysext/install/Tests/Functional/Service/SilentConfigurationUpgradeServiceTest.php+2 −0
- composer.lock+9 −9
Review log 1421
-
Christian Kuhn uploaded patch set 1 11/21/24, 13:29
-
core-ci voted on patch set 1 V -1 11/21/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69943
-
Christian Kuhn uploaded patch set 2
V -111/21/24, 13:54 -
core-ci voted on patch set 2 V -1 11/21/24, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69946
-
Christian Kuhn commented on patch set 2 CR -1 11/21/24, 14:11
guess we'll have to resolve https://github.com/TYPO3/testing-framework/issues/647 first. -
Christian Kuhn uploaded patch set 3
CR -1V -111/26/24, 20:51 -
Christian Kuhn uploaded patch set 4 11/26/24, 21:00
-
core-ci voted on patch set 3 V -1 11/26/24, 21:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70219
-
core-ci voted on patch set 4 V -1 11/26/24, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70220
-
Christian Kuhn uploaded patch set 5
V -111/26/24, 21:18 -
Christian Kuhn commented on patch set 5 11/26/24, 21:21
CustomPlatformDriverMiddlewareTest.php:44removed this one since it is unstable and depends on configuration / db engine too much: some drivers do have additional middlewares, others don't. this makes the foreach->assert() loop below unstable. -
core-ci voted on patch set 5 V +1 11/26/24, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70222
-
Christian Kuhn uploaded patch set 6
V +111/26/24, 21:43 -
core-ci voted on patch set 6 V +1 11/26/24, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70226
-
Garvin Hicking voted on patch set 6 CR +1 V +1 11/26/24, 21:51
-
Christian Kuhn updated the commit message in patch set 7
CR +1V +111/26/24, 21:59 -
core-ci voted on patch set 7 V +1 11/26/24, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70227
-
Garvin Hicking voted on patch set 7 CR +1 V +1 11/26/24, 22:06
-
Stefan Bürk voted on patch set 7 CR +1 V +1 11/27/24, 07:38
-
Christian Kuhn voted on patch set 7 CR +2 V +2 11/27/24, 07:54
-
Christian Kuhn merged patch set 8 11/27/24, 07:54