Review main Merged

87149[TASK] Show enum values in site settings in debug mode

Andreas Nedbal CR +2 V +2 Easy +18 −10 updated 12/18/24, 09:24

Commit message

Adapt the settings editor to match the behavior of
FormEngine to show enum-values next to labels, once
`$GLOBALS['TYPO3_CONF_VARS']['BE']['debug']` is enabled.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Garvin Hicking +1

Issues 1

Files 10

Review log 79

  1. Andreas Nedbal uploaded patch set 1 11/21/24, 14:00

  2. core-ci voted on patch set 1 V +1 11/21/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69947

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 11/26/24, 09:52

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 12/18/24, 09:11

  5. Benjamin Franzke commented on patch set 2 12/18/24, 09:11

    string.ts:35

    This looks fishy – but actually is not. I thought this would allow for XSS injection, but actually is not is insecure, because the outer html literal escapes this string as well. Anyway, I prefer to escape HTML strings always explicitly and therefore switched to: ``` html`[${value}]` ```
  6. Garvin Hicking voted on patch set 2 CR +1 V +1 12/18/24, 09:14

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 12/18/24, 09:18

  8. Oli Bartsch merged patch set 3 12/18/24, 09:19

  9. core-ci voted on patch set 2 V +1 12/18/24, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71361