Review main Merged

87155[TASK] Use DI in FlexFormValueFormatter

Christian Kuhn CR +2 V +2 Normal +30 −71 updated 11/21/24, 16:40

Commit message

FlexFormValueFormatter is a stateless dependency
that can easily use proper DI and be injected
consistently.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 11/21/24, 16:16

  2. core-ci voted on patch set 1 V +1 11/21/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69964

  3. Simon Praetorius voted on patch set 1 CR +1 V +1 11/21/24, 16:24

  4. Andreas Nedbal voted on patch set 1 CR +1 V +1 11/21/24, 16:39

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 11/21/24, 16:40

  6. Christian Kuhn merged patch set 2 11/21/24, 16:40