Review main Merged

87158[BUGFIX] Avoid rendering null values in upgrade docs modal

Elias Häußler CR +2 V +2 Easy +3 −3 updated 11/21/24, 20:00

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Elias Häußler uploaded patch set 1 11/21/24, 19:35

  2. core-ci voted on patch set 1 V +1 11/21/24, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69981

  3. Oliver Hader voted on patch set 1 CR +1 11/21/24, 19:49

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 11/21/24, 19:54

    works for me; appending '' instead of preventing the appending completely is forgivable to me fir brevity.
  5. Oliver Hader voted on patch set 1 V +1 11/21/24, 19:58

  6. Oliver Hader voted on patch set 1 CR +2 11/21/24, 19:59

  7. Torben Hansen voted on patch set 1 CR +1 V +1 11/21/24, 20:00

  8. Oliver Hader voted on patch set 1 V +2 11/21/24, 20:00

  9. Oliver Hader merged patch set 2 11/21/24, 20:00