Review main Merged

87160[TASK] Avoid unused argument rollbackFields

Christian Kuhn CR +2 V +2 Easy +5 −34 updated 11/22/24, 09:30

Commit message

The argument is unused after it has been
given to __construct() and can be removed
together with a helper method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Christian Kuhn uploaded patch set 1 11/21/24, 20:13

  2. core-ci voted on patch set 1 V +1 11/21/24, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69985

  3. Oli Bartsch commented on patch set 1 11/21/24, 20:20

    We might want to relate this patch to #89127
  4. Andreas Nedbal updated the commit message in patch set 2 V +1 11/21/24, 20:57

  5. Andreas Nedbal commented on patch set 2 CR +1 V +1 11/21/24, 20:59

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/21/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69990

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 11/22/24, 09:29

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 11/22/24, 09:30

  9. Christian Kuhn merged patch set 3 11/22/24, 09:30