87161[!!!][FEATURE] Remove ds_pointerField and simplify FlexForm handling
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 72
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+3 −2
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+2 −2
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+4 −1
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+9 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexPrepare.php+20 −17
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+7 −2
- typo3/sysext/backend/Classes/View/ValueFormatter/FlexFormValueFormatter.php+5 −2
- typo3/sysext/backend/Tests/Functional/Controller/FormSelectTreeAjaxControllerTest.phprenamed+9 −5
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexPrepareTest.php+102 −105
- typo3/sysext/backend/Tests/Functional/View/ValueFormatter/FlexFormValueFormatterTest.php+5 −7
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/SuggestWizardControllerTest.php+16 −8
- typo3/sysext/backend/Tests/Unit/Preview/StandardPreviewRendererResolverTest.php+1 −3
- typo3/sysext/core/Classes/Configuration/FlexForm/Exception/AbstractInvalidDataStructureException.php+3 −2
- typo3/sysext/core/Classes/Configuration/FlexForm/Exception/InvalidCombinedPointerFieldException.phpdeleted+0 −21
- typo3/sysext/core/Classes/Configuration/FlexForm/Exception/InvalidDataStructureException.phpcopied+4 −2
- typo3/sysext/core/Classes/Configuration/FlexForm/Exception/InvalidIdentifierException.php+2 −0
- typo3/sysext/core/Classes/Configuration/FlexForm/Exception/InvalidTcaException.php+2 −0
- typo3/sysext/core/Classes/Configuration/FlexForm/Exception/InvalidTcaSchemaException.phprenamed+4 −2
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php7+319 −215
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php+32 −0
Show 52 more files
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+2 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+28 −16
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+41 −34
- typo3/sysext/core/Classes/Resource/Driver/DriverRegistry.php+6 −4
- typo3/sysext/core/Classes/Schema/Field/FlexFormFieldType.php+6 −2
- typo3/sysext/core/Classes/Schema/FlexFormSchemaFactory.php+10 −6
- typo3/sysext/core/Classes/Schema/RelationMapBuilder.php4+23 −15
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php6+27 −7
- typo3/sysext/core/Configuration/TCA/sys_file_storage.php2+1 −2
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst8new+229 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-107047-ExtensionManagementUtilityAddPiFlexFormValue.rstnew+67 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107047-FlexFormEnhancements.rstnew+168 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/Fixtures/DataStructureWithSheetAndExclude.xmlnew+25 −0
- typo3/sysext/core/Tests/Functional/Configuration/FlexForm/FlexFormToolsTest.php2+1792 −610
- typo3/sysext/core/Tests/Functional/DataHandling/Flexform/ActionTest.php+5 −2
- typo3/sysext/core/Tests/Functional/DataHandling/RecordFieldTransformerTest.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_flex/Configuration/TCA/tx_testflex.php+40 −42
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_flex_section_container/Configuration/TCA/tx_testflexsectioncontainer.php+34 −36
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield/Configuration/TCA/Overrides/tt_content.php+1 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_refindex_softref/Configuration/TCA/tx_test_refindex_softref.php+84 −86
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_relation_resolver/Configuration/TCA/Overrides/tt_content.php+4 −8
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_relation_resolver/Configuration/TCA/collection_inner.php+2 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_relation_resolver/Configuration/TCA/typo3tests_contentelementb_collection.php+2 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_select_flex_mm/Configuration/TCA/tx_testselectflexmm_local.php+25 −27
- typo3/sysext/core/Tests/Functional/Hooks/TcaItemsProcessorFunctionsTest.php+118 −26
- typo3/sysext/core/Tests/Functional/Schema/RelationMapBuilderTest.php+412 −0
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+82 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+2 −6
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php2+5 −3
- typo3/sysext/felogin/Configuration/TCA/Overrides/tt_content.php+1 −15
- typo3/sysext/form/Configuration/TCA/Overrides/tt_content.php+0 −14
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+17 −21
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluid_template/Configuration/TCA/Overrides/tt_content.php+1 −12
- typo3/sysext/impexp/Classes/Import.php+8 −4
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php1+10 −5
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInFilledDatabaseTest.php+10 −4
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+1 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeFlex.php+6 −3
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_displaycond.php+293 −299
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+262 −264
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_folder.php+21 −23
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_group.php+51 −53
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_rte.php+73 −75
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_select.php+206 −209
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_t3editor.php+70 −72
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_file.php+62 −64
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_flex.php+289 −304
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_1n1n_child.php+2 −6
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_l10nreadonly.php+2 −4
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_required.php+136 −140
Review log 5480
Show 3555 earlier messages
-
Oli Bartsch uploaded patch set 1 11/21/24, 20:43
-
core-ci voted on patch set 1 V -1 11/21/24, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69988
-
Benni Mack commented on patch set 1 11/22/24, 06:59
sys_file_storage.php:14any chance we make this as a prepatch also in v13? -
Simon Schaufelberger commented on patch set 1 12/16/24, 11:11
ExtensionManagementUtility.php:852ReplyI'll do it! -
Simon Schaufelberger commented on patch set 1 12/16/24, 11:54
ExtensionManagementUtility.php:852ReplyDone: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87504 Please have a look if this fits the requirmentsExtensionUtility.php:136this parameter needs to be after the SelectItem, not inside -
Lina Wolf commented on patch set 1 02/09/25, 06:15
This initiative is very interesting! However, have you considered breaking it down into smaller parts? For example, the deprecation of ExtensionManagementUtility::addPiFlexFormValue() and the introduction of the parameter I suggested in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88105would keep the TCA settings bundled in one place. Could your changes be based on that approach? Additionally, would it make sense to keep the changelog entries separate? While using utility functions like ExtensionManagementUtility and ExtensionUtility is common for extension and site package developers, fewer developers may be concerned with TCA settings for FlexForms. Do you think separating these changelogs would help target the right audience more effectively? -
Benni Mack uploaded patch set 2
V -103/10/25, 17:33 -
Benni Mack commented on patch set 2 03/10/25, 17:36
sys_file_storage.php:14ReplyDone -
core-ci voted on patch set 2 V -1 03/10/25, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75431
-
Benni Mack marked it work in progress 03/22/25, 12:33
-
Benni Mack uploaded patch set 3
V -103/28/25, 08:37 -
core-ci voted on patch set 3 V -1 03/28/25, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76557
-
Benni Mack uploaded patch set 4
V -103/28/25, 09:25 -
core-ci voted on patch set 4 V -1 03/28/25, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76560
-
Benni Mack uploaded patch set 5
V -106/04/25, 14:55 -
core-ci voted on patch set 5 V -1 06/04/25, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79873
-
Oli Bartsch uploaded patch set 6
V -106/11/25, 11:59 -
core-ci voted on patch set 6 V -1 06/11/25, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80196
-
Oli Bartsch uploaded patch set 7
V -107/06/25, 08:39 -
core-ci voted on patch set 7 V -1 07/06/25, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81359
-
Oli Bartsch uploaded patch set 8
V -107/06/25, 09:33 -
core-ci voted on patch set 8 V -1 07/06/25, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81363
-
Oli Bartsch uploaded patch set 9
V -107/06/25, 13:27 -
core-ci voted on patch set 9 V -1 07/06/25, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81368
-
Oli Bartsch uploaded patch set 10
V -107/06/25, 14:38 -
Oli Bartsch uploaded patch set 11 07/06/25, 14:47
-
core-ci voted on patch set 10 V -1 07/06/25, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81372
-
core-ci voted on patch set 11 V -1 07/06/25, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81374
-
Oli Bartsch uploaded patch set 12
V -107/06/25, 15:08 -
core-ci voted on patch set 12 V +1 07/06/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81376
-
Oli Bartsch uploaded patch set 13
V +107/06/25, 15:47 -
core-ci voted on patch set 13 V +1 07/06/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81379
-
Oli Bartsch commented on patch set 13 07/06/25, 16:01
This change is ready for review. -
Oli Bartsch uploaded patch set 14
V +107/08/25, 14:47 -
Oli Bartsch commented on patch set 14 07/08/25, 14:48
ExtensionManagementUtility.php:852ReplyDoneExtensionUtility.php:136ReplyDone -
core-ci voted on patch set 14 V +1 07/08/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81496
-
Georg Ringer commented on patch set 14 07/09/25, 06:20
if we go with breaking, can't we also rename "ds" to something more readable? -
Benni Mack commented on patch set 14 07/09/25, 09:18
Feature-107047-AllowPassingFlexFormDirectlyInAddPluginAndRegisterPlugin.rst:45how about we split this feature away from the breaking change? As a "followup"? -
Oli Bartsch commented on patch set 14 07/09/25, 11:01
Reply
Why do you think that it’s not readable? What is your suggestion? I think this has to really improve the understanding since this requires a lot of change in core and people’s custom code, which might not be possible to automate via TCA Migration.Feature-107047-AllowPassingFlexFormDirectlyInAddPluginAndRegisterPlugin.rst:45ReplyWhat would be the benefit as this, according to the explanation in the rst, is directly linked to the other changes. -
Oli Bartsch commented on patch set 14 07/10/25, 16:31
Feature-107047-AllowPassingFlexFormDirectlyInAddPluginAndRegisterPlugin.rst:45ReplyI’ve thought about this again, and especially considering the deprecation introduced in this patch, it makes sense to introduce the “alternative” option directly here. -
Oli Bartsch uploaded patch set 15
V +107/22/25, 11:33 -
core-ci voted on patch set 15 V -1 07/22/25, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82121
-
Oli Bartsch uploaded patch set 16
V -107/22/25, 11:48 -
Oli Bartsch uploaded patch set 17 07/22/25, 11:56
-
core-ci voted on patch set 16 V -1 07/22/25, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82122
-
core-ci voted on patch set 17 V +1 07/22/25, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82123
-
Benni Mack commented on patch set 17 07/22/25, 18:53
Feature-107047-AllowPassingFlexFormDirectlyInAddPluginAndRegisterPlugin.rst:45ReplyBut then the commit message should state that this change is a new feature -
Oli Bartsch uploaded patch set 18
V +107/23/25, 20:52 -
Oli Bartsch uploaded patch set 19 07/23/25, 20:53
-
core-ci voted on patch set 18 V -1 07/23/25, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82192
-
core-ci voted on patch set 19 V -1 07/23/25, 21:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82193
-
Oli Bartsch uploaded patch set 20
V -107/23/25, 21:07 -
core-ci voted on patch set 20 V +1 07/23/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82195
-
Oli Bartsch commented on patch set 20 07/23/25, 21:19
Reply
DoneFeature-107047-AllowPassingFlexFormDirectlyInAddPluginAndRegisterPlugin.rst:45ReplyDone -
Benni Mack commented on patch set 20 07/23/25, 21:43
FlexFormTools.php:186as this method is internal and only used once in core, we could simply use TcaSchema as first argument, right?RelationMapBuilder.php:68any reason for this closure logic instead of using another class method (with proper comment etc) "processFlexFormStructure"?
-
Simon Schaufelberger commented on patch set 20 07/23/25, 23:47
Breaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:28Without ' as this is plural contextBreaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:55without ' as this is plural contextBreaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:83previouslyBreaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:98feature?Deprecation-107047-DeprecateExtensionUtilityaddPiFlexFormValue.rst:30double space used -
Oli Bartsch uploaded patch set 21
V +107/24/25, 07:29 -
Oli Bartsch commented on patch set 20 07/24/25, 07:31
FlexFormTools.php:186ReplyWe could but I saw extensions are using this, e.g. news and also I actually don't see the benefit of moving this argument to the front.RelationMapBuilder.php:68ReplyNo I just inlined it but I think for those three lines of code no further comment is needed.Breaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:28ReplyDoneBreaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:55ReplyDoneBreaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:83ReplyDoneBreaking-107047-RemovePointerFieldFunctionalityOfTCAFlex.rst:98ReplyDoneDeprecation-107047-DeprecateExtensionUtilityaddPiFlexFormValue.rst:30ReplyDone -
core-ci voted on patch set 21 V +1 07/24/25, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82221
-
Benni Mack commented on patch set 21 07/24/25, 08:01
FlexFormTools.php:186ReplyDone -
Benni Mack uploaded patch set 22
V +107/24/25, 08:45 -
Benni Mack updated the commit message in patch set 23 07/24/25, 08:46
-
core-ci voted on patch set 22 V +1 07/24/25, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82223
-
core-ci voted on patch set 23 V +1 07/24/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82224
-
Benni Mack voted on patch set 23 CR +1 V +1 07/24/25, 12:49
-
Christian Kuhn commented on patch set 23 07/28/25, 17:32
FlexFormTools.php:50we could / should make clear that the 'TCA as array' part is an internal thing and 'casual' consumers should rely on the schema stuff only?FlexFormTools.php:695not 100% sure about the exception handling changes within this change. i'd like to have a slightly closer look on this since we probably want some to be global and bubble up, and others shouldn't.RelationMapBuilder.php:34i'm not 100% sure about this part of the change since FF has various unresolved quirks with relations. i'm thinking about extracting this part to an own change to sort out details. i'd suggest we talk about this part, and will ping you, Oli.ExtensionManagementUtility.php:896would be good to rename $piKeyToMatch to $_ - this is how i do this to make very obvious that this argument is unused and only still there to not break the signature. OTOH it does not matter much with the entire method being deprecated ;)FlexFormToolsTest.php:80could we inline the parts that are *really* needed for single tests into the single tests again and avoid the setUp() again? this creates some state that is hard to remember and only a couple of tests actually use them, and then override parts of it again. i think those tests would be easier to grasp if they keep their set-up tca in themselfs, plus it would be more obvious that so many other tests don't depend on it at all. what do you think?PagesAndTtContentWithRelationsAndSoftrefsTest.php:194oh. an old int-key indexed select item ... nice drive-by catch! -
Christian Kuhn commented on patch set 23 07/29/25, 13:59
RelationMapBuilder.php:34Replyscratch that. this part of the change only adapts what we have already. -
Christian Kuhn commented on patch set 23 07/29/25, 14:01
this sentence is not true as such, would be good to adapt a bit. -
Oli Bartsch uploaded patch set 24
CR +1V +107/29/25, 18:23 -
core-ci voted on patch set 24 V +1 07/29/25, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82507
-
Oli Bartsch uploaded patch set 25
V +107/29/25, 20:44 -
core-ci voted on patch set 25 V -1 07/29/25, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82510
-
Oli Bartsch uploaded patch set 26
V -107/29/25, 20:59 -
Oli Bartsch commented on patch set 25 07/29/25, 21:02
FlexFormTools.php:50ReplyI added comprehensive class comment and function documentation for this.FlexFormTools.php:695ReplyRevisited those exceptions and have a good feeling. I have only changed exceptions which should be caught, e.g. I have migrated "UnexpectedValueException" to "InvalidDataStructureException" because those might be triggered "on purpose" during build in the RelationMapBuilder etc.ExtensionManagementUtility.php:896ReplyDoneFlexFormToolsTest.php:80ReplyDone -
Oli Bartsch commented on patch set 26 07/29/25, 21:02
Reply
Done -
core-ci voted on patch set 26 V +1 07/29/25, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82511
-
Christian Kuhn voted on patch set 26 CR +1 V +1 07/29/25, 22:04
-
Benni Mack voted on patch set 26 CR +1 V +1 07/30/25, 05:39
-
Oli Bartsch voted on patch set 26 CR +2 V +2 07/30/25, 05:47
-
Oli Bartsch merged patch set 27 07/30/25, 05:47
ExtensionManagementUtility.php:852