87162[BUGFIX] Consider virtual tables in ElementInformationController
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1115
-
Oli Bartsch uploaded patch set 1 11/21/24, 20:47
-
Garvin Hicking voted on patch set 1 CR +1 11/21/24, 20:48
-
core-ci voted on patch set 1 V +1 11/21/24, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69989
-
Andreas Kienast commented on patch set 1 CR +1 V +1 11/22/24, 10:21
The patch works, but emits the following JavaScript error: ``` Uncaught (in promise) SyntaxError: identifier must be of type string (at module-state-storage.js?bust=1732259697:13:128) at update (module-state-storage.js?bust=1732259697:13:128) at immediate-action-element.js?bust=1732259697:13:1624 ``` Not sure tho if that's related to the patch. -
Oli Bartsch uploaded patch set 2
CR +1V +111/27/24, 11:03 -
Oli Bartsch commented on patch set 2 11/27/24, 11:05
Reply
Actually this bug was revealed by the fact that the info now works for folders again. So fixed this now too. -
Oli Bartsch uploaded patch set 3 11/27/24, 11:08
-
core-ci voted on patch set 2 V +1 11/27/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70251
-
core-ci voted on patch set 3 V -1 11/27/24, 11:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70252
-
Oli Bartsch uploaded patch set 4
V -111/27/24, 11:26 -
core-ci voted on patch set 4 V +1 11/27/24, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70254
-
Garvin Hicking voted on patch set 4 CR +1 V +1 11/28/24, 08:13
-
Andreas Kienast voted on patch set 4 CR +1 V +1 11/28/24, 08:22
-
Oli Bartsch voted on patch set 4 CR +2 V +2 11/28/24, 09:01
-
Oli Bartsch merged patch set 5 11/28/24, 09:01