87164[BUGFIX] Restore setting default lib.parseFunc.allowTags / denyTags
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscript3+4 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php7+6 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/pages.csvnew+10 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/ParseFuncTest.phpnew+101 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −0
Review log 1721
-
Benni Mack uploaded patch set 1 11/22/24, 09:00
-
core-ci voted on patch set 1 V +1 11/22/24, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70023
-
Benjamin Franzke commented on patch set 1 11/22/24, 10:23
-
Benni Mack commented on patch set 1 11/22/24, 10:27
ContentObjectRenderer.php:3157Replynot necessarily. because we have $allowTags === [] below (around line 3317) -
Garvin Hicking commented on patch set 1 11/22/24, 13:25
ContentObjectRenderer.php:3157ReplyThis should probably work out, I'll try to find time to add a test case for this addToList(wbr) scenario. Thanks! -
Garvin Hicking uploaded patch set 2
V +111/25/24, 12:15 -
core-ci voted on patch set 2 V -1 11/25/24, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70134
-
Garvin Hicking commented on patch set 2 11/25/24, 12:32
ContentObjectRenderer.php:3157Reply@ben@bnf.dev We discussed this in the merger meeting only via voice. I added some notes of this in https://review.typo3.org/c/Packages/TYPO3.CMS/+/86763 I've now added a test for this, which currently fails - because as Benjamin indicated, we are missing an `allowTags = *` definition. Without this, `addToList` will still have the issue that it resolves to only `wbr` in the example case, and not `*,wbr`. If that test is modified to include `allowTags = *` it would pass, which we would achieve by adding `allowTags = *` to the former place of `typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscript` (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/84824). I've added such a line to https://review.typo3.org/c/Packages/TYPO3.CMS/+/86763 again to show that this would no longer break tests (I removed `denyTags=*` which was the culprit of my previous approach). IMO there are two ways to address this: * Retroactively make https://forge.typo3.org/issues/104220 a breaking change and document that `addToList()` operations will fail now, when no `allowTags` has been set. * Re-introduce the `allowTags = *` definition together with this change and new tests which will properly accept a `*,xxx` definition. This is my preferred choice. @benni@typo3.org wdyt? -
Benni Mack commented on patch set 2 12/02/24, 18:16
ContentObjectRenderer.php:3157ReplyI agree. let's go with the 2nd option (= your preferred choice) -
Garvin Hicking uploaded patch set 3
V -112/03/24, 10:50Unbreak tests specify commit message -
core-ci voted on patch set 3 V -1 12/03/24, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70513
-
Garvin Hicking uploaded patch set 4
V -112/03/24, 11:24 -
core-ci voted on patch set 4 V +1 12/03/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70521
-
Garvin Hicking commented on patch set 4 CR +1 V +1 12/03/24, 13:01
ContentObjectRenderer.php:3157ReplyAlright. I had to add fsc to the test to make the test pass. From my side, this one is good to go now. -
Benni Mack commented on patch set 4 12/04/24, 09:28
ParseFunc.typoscript:36shouldn't we switch back to "allowTags = {$styles.content.allowTags}" the constants still exist. Even though I suggest to remove both options in FSC for v14 completely. -
Garvin Hicking commented on patch set 4 12/04/24, 17:00
ParseFunc.typoscript:36Replyt would effectively roll back the "trust" in HTMLSanitzer that was to be established with the related change in first place. Personally I would go with "*" here to establish this and be safe to remove it more easily, because we can continue to test this in real life. I haven't seen reports for 13.4.0 or 13.4.1 reporting trouble with allowTags (other than this one here), so I don't think a "full revert" of this is required. -
Benni Mack commented on patch set 4 12/04/24, 17:05
ParseFunc.typoscript:36Replyalright! -
Garvin Hicking commented on patch set 4 12/10/24, 08:26
ContentObjectRenderer.php:3157ReplyWould like to resolve this, please get in touch if you feel otherwise @ben@bnf.dev -
Benjamin Franzke voted on patch set 4 CR +1 12/10/24, 10:14
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 12/10/24, 10:21
-
Benjamin Franzke merged patch set 5 12/10/24, 10:28
ContentObjectRenderer.php:3157