Review main Merged

87166[BUGFIX] Properly resolve file extension restrictions in overrideChildTca

Oli Bartsch CR +2 V +2 Easy +20 −21 updated 11/24/24, 19:58

Commit message

TcaPreparation does now also properly resolve allowed /
disallowed file extensions, configured in overrideChildTca
of fields other than TCA type "file", e.g. an inline
field whose child defines "file" fields.

This can be verified with styleguide:

tx_styleguide_flex > flex_3 > inline_1 > file_1

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/22/24, 10:08

  2. core-ci voted on patch set 1 V +1 11/22/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70028

  3. Benni Mack voted on patch set 1 CR +1 V +1 11/22/24, 14:35

  4. Nikita Hovratov voted on patch set 1 CR +1 V +1 11/22/24, 18:02

  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/24/24, 19:13

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 11/24/24, 19:58

  7. Oli Bartsch merged patch set 2 11/24/24, 19:58