Review main Merged

87169[TASK] Reduce mess in CharsetConverter

Christian Kuhn CR +2 V +2 Hard +59 −269 updated 11/22/24, 14:26

Commit message

The fishy class and its unit tests are cleaned up a bit:
* Some more types
* Turn some properties into constants
* Avoid test assertions that don't test subject data

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 810

  1. Christian Kuhn uploaded patch set 1 11/22/24, 11:14

  2. core-ci voted on patch set 1 V +1 11/22/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70033

  3. Tymoteusz Motylewski commented on patch set 1 11/22/24, 13:38

    CharsetConverter.php:31

    this is not a byte val any more, so maybe a better name would be NO_CHAR_VAL ?
  4. Christian Kuhn uploaded patch set 2 V +1 11/22/24, 14:00

  5. Christian Kuhn commented on patch set 2 11/22/24, 14:01

    CharsetConverter.php:31 Reply

    Done
  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 11/22/24, 14:04

  7. core-ci voted on patch set 2 V +1 11/22/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70038

  8. Simon Praetorius voted on patch set 2 CR +1 V +1 11/22/24, 14:26

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 11/22/24, 14:26

  10. Christian Kuhn merged patch set 3 11/22/24, 14:26