Review main Merged

87171[BUGFIX] Handle `has-change` state in FlexForm section container

Oli Bartsch CR +2 V +2 Easy +23 −21 updated 12/04/24, 12:54

Commit message

With #105096, the `has-change` state functionality
was fixed for FormEngine elements and corresponding
containers (Resolving inheritance bugs, etc.) However,
- as always - a special case however is flex form,
in detail the so called "section container".

This therefore applies the same fix to the section
container component as well. Adding the `has-change`
class to the corresponding section container label
instead of the container element itself. This as
mentioned prevents wrong inheritance, which previously
resulted in visually marking all section container
fields as changed when adding a new section container.

Side note: This therefore unifies the used label structure
by using fieldset > legend with corresponding classes.

Additionally, this also fixes the corresponding
container elements of those sections. In case
such container is removed, the `has-change`
class is now properly applied to the section
container label to visualize the change state.

This can be verified with styleguide:

tx_styleguide_flex > flex_2

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 710

  1. Oli Bartsch uploaded patch set 1 11/22/24, 11:35

  2. core-ci voted on patch set 1 V -1 11/22/24, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70036

  3. Oli Bartsch uploaded patch set 2 V -1 11/22/24, 14:19

  4. core-ci voted on patch set 2 V +1 11/22/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70042

  5. Oli Bartsch rebased onto patch set 3 V +1 11/26/24, 11:49

  6. core-ci voted on patch set 3 V +1 11/26/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70201

  7. Benni Mack voted on patch set 3 CR +1 V +1 12/04/24, 09:45

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 12/04/24, 10:10

  9. Oli Bartsch voted on patch set 3 CR +2 V +2 12/04/24, 12:54

  10. Oli Bartsch merged patch set 4 12/04/24, 12:54