Review 13.4 Merged

87180[BUGFIX] Handle db value null in AbstractItemProvider

Benni Mack CR +2 V +2 Easy +43 −0 updated 11/22/24, 07:36

Commit message

While "item-able" field types do not support null values
in the backend, it is still possible null was added via
external API (e.g. extbase).

A guard clause is added for null and will return an empty
array if encountered. This is now needed, as GU:trimExplode
is strict since TYPO3 v13.

In future, it could be considered to introduce option `nullable`
for these field types as well. This would be especially useful
for optional relations and would erase the need to define a
default item like "Please select...".

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 11/22/24, 07:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/22/24, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70020

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/22/24, 07:36

  4. Benni Mack merged patch set 2 11/22/24, 07:36