Review 13.4 Merged

87181[BUGFIX] Return HTTP 400 if request is invalid

Benni Mack CR +2 V +2 Easy +29 −9 updated 12/11/24, 11:09

Commit message

The request may be an unparsable URL or might
have other defects.

Specifically, the URI class may throw an
exception if something is wrong.
Catch this exception and bail out with a
400 bad request status.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 56

  1. Benni Mack commented on patch set 1 11/22/24, 09:55

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/22/24, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70024

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/22/24, 10:02

  4. Benni Mack merged patch set 2 11/22/24, 10:02

  5. Christoph Lehmann commented on patch set 2 12/10/24, 22:09

    With this, \TYPO3\CMS\Core\Error\AbstractExceptionHandler::IGNORED_EXCEPTION_CODES can be cleaned up, or? Especially: 1436717275, // Request with unsupported HTTP method 1436717270, // Client sends a header with an invalid name 1436717269, // Client sends a header with an invalid value
  6. Benni Mack commented on patch set 2 12/11/24, 11:09

    Reply

    yes. can be done (separate / new issue)