Review main Merged

87192[TASK] Avoid some useless test assertions

Christian Kuhn CR +2 V +2 Easy +0 −22 updated 11/22/24, 16:27

Commit message

PSR-7 MessageInterface forces getHeader(): array,
there is no point in asserting this in tests.
Avoiding this makes phpstan more happy.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 11/22/24, 14:13

  2. Christian Kuhn updated the commit message in patch set 2 11/22/24, 14:14

  3. core-ci voted on patch set 1 V +1 11/22/24, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70040

  4. core-ci voted on patch set 2 V +1 11/22/24, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70041

  5. Simon Praetorius voted on patch set 2 CR +1 V +1 11/22/24, 14:28

  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 11/22/24, 14:28

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 11/22/24, 16:27

  8. Christian Kuhn merged patch set 3 11/22/24, 16:27