87194[BUGFIX] Ensure user setup module is available in any workspace
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1316
-
Benni Mack uploaded patch set 1 11/22/24, 15:26
-
core-ci voted on patch set 1 V -1 11/22/24, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70050
-
Oli Bartsch uploaded patch set 2
V -111/22/24, 16:05 -
core-ci voted on patch set 2 V +1 11/22/24, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70054
-
Benni Mack updated the commit message in patch set 3
V +111/22/24, 16:19 -
core-ci voted on patch set 3 V +1 11/22/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70056
-
Oli Bartsch voted on patch set 3 CR +1 V +1 11/22/24, 16:37
-
Christian Kuhn commented on patch set 3 V +1 11/22/24, 16:50
ok, exception gone. fun part: a user with access to 'user setup' only now sees top toolbar, and gets the user setup module rendered. clicking on the toolbar 'user setup' then makes the toolbar vanish, and only user setup is shown ... so at least, there are some more fishy details with this access setup edge case. -
Oli Bartsch commented on patch set 3 11/22/24, 17:15
Reply
I can't reproduce this behaviour. Toolbar is always visible for me. However as expected, module menu and page tree are not displayed, but the toolbar contains next the user "button", bookmarks, open docs and cache icons. -
Markus Klein commented on patch set 3 11/22/24, 17:44
Reply
> this access setup edge case It's been a while I created this issue and I can't remember the exact details, but I suspect it was one of our Seminar-instances, where some users only see our custom BE module (w/o page tree) and are assigned to a draft workspace, so they can propose changes by using the BE module. -
Benni Mack commented on patch set 3 01/08/25, 17:15
Reply
Hey Markus, if you want to get this in, I hope you can review + test + vote this change. Otherwise I will abandon this change. -
Markus Klein commented on patch set 3 01/09/25, 07:27
Reply
Hey Benni, sure, will try to test this today. -
Georg Ringer voted on patch set 3 CR +1 V +1 01/13/25, 20:54
-
Christian Kuhn commented on patch set 3 01/14/25, 10:03
Reply
Done -
Oli Bartsch voted on patch set 3 CR +2 V +2 01/14/25, 10:55
-
Oli Bartsch merged patch set 4 01/14/25, 10:55