Review main Abandoned Breaking

87195[!!!][TASK] Avoid obsolete $charset in sanitizeFileName()

Christian Kuhn CR 0 V 0 Normal +62 −61 updated 11/22/24, 17:00

Commit message

DriverInterface:
public function sanitizeFileName(string $fileName, string $charset = ''): string;

LocalDriver implementation:
public function sanitizeFileName(string $fileName, string $charset = 'utf-8'): string

All consumers (mainly ResourceStorage) call the method without
handing over the second argument. The uselessness of the second
argument has been stated in an @todo for a while already. The
patch drops the second argument in interface and implementation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 2

  1. Christian Kuhn uploaded patch set 1 11/22/24, 15:57

  2. Christian Kuhn abandoned the change 11/22/24, 17:00