Review main Merged Breaking

87212[!!!][TASK] Avoid obsolete $charset in sanitizeFileName()

Christian Kuhn CR +2 V +2 Normal +62 −61 updated 11/22/24, 16:52

Commit message

DriverInterface:
public function sanitizeFileName(string $fileName, string $charset = ''): string;

LocalDriver implementation:
public function sanitizeFileName(string $fileName, string $charset = 'utf-8'): string

All consumers (mainly ResourceStorage) call the method without
handing over the second argument. The uselessness of the second
argument has been stated in an @todo for a while already. The
patch drops the second argument in interface and implementation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 56

  1. Christian Kuhn uploaded patch set 1 11/22/24, 16:04

  2. core-ci voted on patch set 1 V +1 11/22/24, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70053

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 11/22/24, 16:18

  4. Simon Praetorius voted on patch set 1 CR +1 V +1 11/22/24, 16:51

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 11/22/24, 16:52

  6. Christian Kuhn merged patch set 2 11/22/24, 16:52