Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

87214[TASK] Prevent superfluous SQL query in SlugService

Christoph Lehmann CR 0 V 0 Easy +14 −21 updated 03/28/25, 09:12

Commit message

Translations are resolved twice recursively in SlugService::resolveSubPages().

1. Get subpages
2. Get translations
3. Call PageRepository::getPagesOverlay()
4. Call PageRepository::getPageOverlaysForLanguage() <- Get translations again

This removes the 2. step, because it's done in 4. anyway.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 8
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/87214/8 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/87214/8 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 1

Review log 2028

Show 23 earlier messages
  1. Christoph Lehmann uploaded patch set 1 11/22/24, 22:43

  2. core-ci voted on patch set 1 V -1 11/22/24, 22:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70065

  3. Christoph Lehmann uploaded patch set 2 V -1 11/22/24, 23:08

  1. core-ci voted on patch set 2 V -1 11/22/24, 23:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70066

  2. Christoph Lehmann uploaded patch set 3 V -1 11/22/24, 23:48

  3. core-ci voted on patch set 3 V +1 11/22/24, 23:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70067

  4. Christoph Lehmann updated the commit message in patch set 4 V +1 11/23/24, 00:17

  5. core-ci voted on patch set 4 V +1 11/23/24, 00:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70068

  6. Markus Klein commented on patch set 4 11/23/24, 13:55

    Can you maybe elaborate a bit where exactly the removed functionality is covered in the nested call? I fail to see this on "first glance", without doing a deep-dive.

    SlugService.php:242

    array typehint
  7. Christoph Lehmann commented on patch set 5 V +1 11/25/24, 11:41

    Published edit on patch set 4.
  8. Christoph Lehmann updated the commit message in patch set 6 11/25/24, 11:43

  9. Christoph Lehmann commented on patch set 6 11/25/24, 11:43

    SlugService.php:242 Reply

    Done
  10. core-ci voted on patch set 5 V +1 11/25/24, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70130

  11. core-ci voted on patch set 6 V +1 11/25/24, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70131

  12. Christoph Lehmann updated the commit message in patch set 7 V +1 11/25/24, 12:01

  13. core-ci voted on patch set 7 V +1 11/25/24, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70132

  14. Oliver Klee commented on patch set 7 11/25/24, 12:10

    SlugService.php:242

    ```suggestion function (array $pageOverlay): bool { ```
  15. Christoph Lehmann commented on patch set 8 V +1 11/25/24, 12:35

    Published edit on patch set 7.
  16. Christoph Lehmann commented on patch set 8 11/25/24, 12:35

    SlugService.php:242 Reply

    Fix applied.
  17. core-ci voted on patch set 8 V +1 11/25/24, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70137

  18. Markus Klein commented on patch set 8 11/28/24, 11:12

  19. Markus Klein voted on patch set 8 CR +1 V +1 11/28/24, 11:17

  20. Stefan Bürk commented on patch set 8 11/28/24, 12:32

    Not sure if this is a change of behaviour. `getQueryBuilderForPages` used to retrieve the first language pages changes the QueryBuilder restriction containing also hidden pages along with workspace restriction, which the pagerepository not contains but uses the FrontendGroupRestriction on top. That needs proper and deeper investigation along with eventually additional tests.
  21. Markus Klein commented on patch set 8 CR 0 V 0 11/28/24, 15:46

    Reply Unresolved

    Good catch Stefan. I knew I forgot to check something. Workspaces.
  22. Benni Mack commented on patch set 8 01/08/25, 11:33

    how to continue here?
  23. Oliver Klee wrote 01/08/25, 11:35

    Removed cc Oliver Klee.
  24. Christoph Lehmann commented on patch set 8 01/16/25, 15:53

    Reply

    Need to check, but have less spare time atm.
  25. Benni Mack marked it work in progress 03/28/25, 09:12