Review 13.4 Merged

87219[TASK] Update `firebase/php-jwt ^6.10.2` and remove composer patch

Stefan Bürk CR +2 V +2 Normal +13 −134 updated 11/24/24, 19:57

Commit message

TYPO3 monorepo used a composer patch based on [1]
for the `firebase/php-jwt` package to resolve the
one or other PHP 8.4 issue to allow testing TYPO3
against PHP 8.4. The pull-request has been merged
already months ago and a release has been finally
made [2].

This change removes the composer patch introduced
with #104578 and updates the package version to
ensure having required fixes on board even for
classic mode installations.

Used command(s):

> composer remove --dev "cweagans/composer-patches"
> composer config --no-plugins --no-interaction \
    --unset allow-plugins.cweagans/composer-patches
> composer config --no-plugins --no-interaction \
    --unset extra.composer-exit-on-patch-failure
> composer config --no-plugins --no-interaction \
    --unset extra.patches-file
> composer require -d typo3/sysext/core --no-update \
    "firebase/php-jwt":"^6.10.2"
> composer require "firebase/php-jwt":"^6.10.2"
> rm -rf Build/patches

[1] https://github.com/firebase/php-jwt/pull/572
[2] https://github.com/firebase/php-jwt/releases/tag/v6.10.2

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 35

  1. Stefan Bürk uploaded patch set 1 11/24/24, 14:08

  2. core-ci voted on patch set 1 V +1 11/24/24, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70102

  3. core-ci commented on patch set 1 11/24/24, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70103

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 11/24/24, 19:57

  5. Stefan Bürk merged patch set 2 11/24/24, 19:57