Review main Merged

87221[BUGFIX] Fix highlighting of "Progress trackers" in styleguide menu

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 11/25/24, 07:50

Commit message

The highlighting of active menu items in the styleguide menu relies on
correctly set `currentAction` variables, which was not given for the
progress trackers view.

This is now fixed in this commit.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Philipp Kuhlmay +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Philipp Kuhlmay +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 11/25/24, 07:15

  2. Andreas Kienast commented on patch set 1 11/25/24, 07:15

    Note: I've set @typo3@treupo.de as the author as he provided the original diff in the ticket.
  3. core-ci voted on patch set 1 V +1 11/25/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70123

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/25/24, 07:23

  5. Philipp Kuhlmay commented on patch set 1 CR +1 V +1 11/25/24, 07:40

    Looks good to me and works :)
  6. Andreas Kienast voted on patch set 1 CR +2 V +2 11/25/24, 07:43

  7. Andreas Kienast merged patch set 2 11/25/24, 07:50