Review main Merged

87223[TASK] Add link from CSP module to see active mutations

Garvin Hicking CR +2 V +2 Easy +43 −7 updated 01/25/25, 11:10

Commit message

There is a dedicated module "Admin Tools > Content Security Policy",
which did not point users into the direction of
"System > Configuration > Content Security Policy Mutations".

This patch increases the visibility of that configuration option
by adding a new crosslink button the the CSP module overview.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sybille Peters +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sybille Peters +1
    • Christian Kuhn +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2125

  1. Garvin Hicking uploaded patch set 1 11/25/24, 10:06

  2. core-ci voted on patch set 1 V +1 11/25/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70126

  3. Jasmina Ließmann uploaded patch set 2 V +1 11/28/24, 20:38

  4. core-ci voted on patch set 2 V -1 11/28/24, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70316

  5. Jasmina Ließmann uploaded patch set 3 V -1 11/28/24, 20:49

  6. core-ci voted on patch set 3 V +1 11/28/24, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70318

  7. Jasmina Ließmann commented on patch set 3 11/28/24, 20:56

    After consulting with @gh@faktor-e.de, I adapted the patch. The link is now placed within an introductory text. There is currently no uniform link styling within continuous text; colored links are usually tied to a module. I suggest that we tackle link styling within continuous text in a separate patch and then adjust it in various modules.
  8. Oliver Hader wrote 11/29/24, 10:51

    Topic set to csp
  9. Garvin Hicking commented on patch set 3 11/29/24, 11:10

    Reply

    Thanks so much for your help, IMO this is better than my approach for more consistency. (not voting on the patch attributed by me, but I'm supporting this patchset!)
  10. Christian Kuhn voted on patch set 3 CR +1 V +1 11/29/24, 11:23

  11. Stefan Bürk voted on patch set 3 CR +1 V +1 11/29/24, 11:29

  12. Stefan Bürk voted on patch set 3 CR -1 11/29/24, 15:07

  13. Sybille Peters commented on patch set 3 CR +1 V +1 12/01/24, 15:49

    CspModule.html:21

    Unfortunately, you can't really see that "Configuration" is a link (and I would really not expect a link there as user). This is not really specific to this patch but a general problem in the BE. You could add markup to make it look like a link. I am pretty sure this goes too far because it is not really an action and it would make it look too prominent, but maybe something like enclosing it in: <button class="btn btn-default">
  14. Sybille Peters commented on patch set 3 V 0 12/01/24, 15:54

    CspModule.html:21

    Should this jump directly to the "Content Security Policy Mutations"? Because that doesn't work for me.
  15. Garvin Hicking uploaded patch set 4 CR +1 V +1 12/02/24, 11:54

  16. Garvin Hicking commented on patch set 4 12/02/24, 11:56

    CspModule.html:21 Reply

    Yes; Jasmina and me are aware of the "missing" styling. We'd like to tackle this with a separate commit, which would also add this styling to the styleguide, and would then take effect for this link here, too. IMO we could merge this already before such a change, because it raises awareness and the link being a link is not absolutely required to have a benefit from the message itself already. Would that be ok with you?

    CspModule.html:21 Reply

    True, there were single quotes missing. Fixed now.
  17. core-ci voted on patch set 4 V +1 12/02/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70454

  18. Sybille Peters commented on patch set 4 CR +1 V +1 12/02/24, 12:16

    CspModule.html:21 Reply

    > Would that be ok with you? yes, absolutely.
  19. Oliver Hader voted on patch set 4 CR +1 V +1 12/03/24, 07:54

  20. Garvin Hicking commented on patch set 4 CR -1 12/03/24, 07:56

    Waiting for @stefan@buerk.tech to review (f:sanitize)
  21. Stefan Bürk voted on patch set 4 CR +1 12/05/24, 13:14

  22. Christian Kuhn voted on patch set 4 CR +1 V +1 12/05/24, 13:15

  23. Garvin Hicking voted on patch set 4 CR +2 V +2 12/05/24, 13:15

  24. Garvin Hicking merged patch set 5 12/05/24, 13:37

  25. Lina Wolf commented on patch set 5 01/25/25, 11:10