Review main Merged

87230[BUGFIX] Align markup in scheduler forms to match display in formengine forms

Jasmina Ließmann CR +2 V +2 Hard +303 −285 updated 12/19/24, 18:04

Commit message

With #104676, the form styling was changed, resulting in a changed
appearance/behavior of form groups that are nested in multiple form
rows. The changed form styling explicitly removes the spacing of the
last form group in a form section.

Since each form group in the scheduler was previously in its own form
row, this condition was always met and resulted in a reduced spacing
between most form fields within the scheduler add/edit forms.

This patch restores the spacing between the form fields in scheduler
add/edit forms by using only one form row per form section.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 710

  1. Jasmina Ließmann uploaded patch set 1 11/25/24, 20:53

  2. core-ci voted on patch set 1 V +1 11/25/24, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70165

  3. Jasmina Ließmann uploaded patch set 2 V +1 11/25/24, 21:00

  4. core-ci voted on patch set 2 V +1 11/25/24, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70166

  5. Jasmina Ließmann updated the commit message in patch set 3 V +1 12/05/24, 14:52

  6. core-ci voted on patch set 3 V +1 12/05/24, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70661

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 12/10/24, 09:45

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 12/19/24, 17:54

  9. Jasmina Ließmann voted on patch set 3 CR +2 V +2 12/19/24, 17:55

  10. Jasmina Ließmann merged patch set 4 12/19/24, 18:04